From: Keith David Bershatsky <esq@lawlist.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: John Wiegley <jwiegley@gmail.com>,
Marcin Borkowski <mbork@mbork.pl>,
22873@debbugs.gnu.org, Richard Stallman <rms@gnu.org>
Subject: bug#22873: Can we support multiple Cursors?
Date: Tue, 29 Mar 2016 10:26:21 -0700 [thread overview]
Message-ID: <m2vb45ureq.wl%esq@lawlist.com> (raw)
In-Reply-To: <m2oaayavh1.wl%esq@lawlist.com>
Thank you, Eli, for taking a look at the 7th working draft of mc.
Essentially, mc_calc is called at only one location depending on how Emacs was built:
* nsterm.m when built --with-ns.
* w32term.c when built for Windows.
* xterm.c when built --with-x.
All three of those files have similarities, and some of the functions in each file are either the same or similar. I felt that tacking mc_calc onto the heels of a function from `xdisp.c` and putting in exceptions (to prevent it from always being called), is not as clean as putting it only where it was truly needed. In a nutshell, I'm just following in the footsteps of my predecessors as to cursors for Emacs on Windows, OSX and X11.
I have made a note on my todo-list to add support for alternative methods for the end user to define colors: [1.0 0.0 0.0]; "red"; "#FF0000"; (255, 0, 0); (65535, 0, 0) -- with some way to distinguish between the last two forms. (1.0 is used by OSX; 255 is used by Windows; and 65535 is used by X11).
Keith
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
At Tue, 29 Mar 2016 17:58:21 +0300,
Eli Zaretskii wrote:
>
> * * *
> >
> > mc_calc now runs from the applicable nsterm.m/w32term.c/xterm.c, instead of xdisp.c.
>
> Why is that a good idea? You have 3 almost identical copies of the
> same code, which goes against our long-time trend to have terminal
> independent code only once, for easier maintenance.
>
> > ((oddp current-column)
> > (list pos "bar" [1.0 0.0 0.0])) ;; red
> > ((evenp current-column)
> > (list pos "bar" [0.0 0.0 1.0])))))) ;; blue
>
> That's not how we specify colors in Emacs, not on the user level,
> anyway. I don't think I like this design. Why not use the existing
> mechanisms for specifying the cursor color?
next prev parent reply other threads:[~2016-03-29 17:26 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 18:44 bug#22873: 25.1.50; Feature Request -- Multiple Cursors (built-in support) Keith David Bershatsky
2016-03-03 6:30 ` bug#22873: Can we support multiple Cursors? John Wiegley
2016-03-03 6:30 ` John Wiegley
2016-03-03 6:54 ` bug#22873: " Marcin Borkowski
2016-03-03 6:54 ` Marcin Borkowski
2016-03-03 11:20 ` bug#22873: " Richard Stallman
2016-03-03 15:05 ` Marcin Borkowski
2016-03-03 15:05 ` Marcin Borkowski
2016-03-04 9:19 ` Richard Stallman
2016-03-04 9:19 ` Richard Stallman
2016-03-04 14:59 ` Stefan Monnier
2016-03-04 22:18 ` Magnar Sveen
2016-03-05 2:16 ` Stefan Monnier
2016-03-05 13:00 ` Richard Stallman
2016-03-06 4:47 ` John Wiegley
2016-03-06 20:30 ` Clément Pit--Claudel
2016-03-08 4:53 ` Stefan Monnier
2016-03-06 20:33 ` Clément Pit--Claudel
2016-03-08 4:55 ` Stefan Monnier
2016-03-05 12:58 ` Richard Stallman
2016-03-03 11:20 ` Richard Stallman
2016-03-04 23:16 ` Keith David Bershatsky
2016-03-05 6:59 ` Marcin Borkowski
2016-03-09 6:50 ` Keith David Bershatsky
2016-03-09 6:27 ` Keith David Bershatsky
2016-03-09 6:45 ` Keith David Bershatsky
2016-03-09 16:03 ` Eli Zaretskii
2016-03-09 18:30 ` Keith David Bershatsky
2016-03-11 7:18 ` Keith David Bershatsky
2016-03-14 18:35 ` Keith David Bershatsky
2016-03-14 18:49 ` Eli Zaretskii
2016-03-14 22:38 ` Keith David Bershatsky
2016-03-16 8:00 ` Keith David Bershatsky
2016-03-18 4:00 ` Keith David Bershatsky
2016-03-26 23:58 ` John Wiegley
2016-03-29 3:45 ` Keith David Bershatsky
2016-03-29 14:58 ` Eli Zaretskii
2016-03-29 17:26 ` Keith David Bershatsky [this message]
2017-06-25 22:09 ` Keith David Bershatsky
2017-07-30 17:39 ` Keith David Bershatsky
2017-08-11 0:00 ` bug#22873: Can we support multiple cursors? Keith David Bershatsky
2017-08-13 18:19 ` Keith David Bershatsky
2017-08-13 18:36 ` Eli Zaretskii
2017-08-14 3:20 ` Keith David Bershatsky
2017-08-14 15:01 ` Eli Zaretskii
2017-08-14 20:35 ` Keith David Bershatsky
2017-12-27 17:13 ` bug#22873: #22873 (multiple fake cursors); and, #17684 (crosshairs) Keith David Bershatsky
2017-12-27 23:55 ` John Wiegley
2017-12-28 1:20 ` bug#22873: #22873 (multiple fake cursors) Keith David Bershatsky
2017-12-28 1:26 ` Keith David Bershatsky
2018-07-17 19:09 ` bug#22873: #22873 (multiple fake cursors); and, #17684 (crosshairs) Keith David Bershatsky
2018-08-29 6:39 ` Keith David Bershatsky
2019-05-03 0:48 ` Keith David Bershatsky
2019-05-06 18:39 ` Keith David Bershatsky
2019-05-28 8:31 ` Keith David Bershatsky
2019-06-02 7:29 ` Keith David Bershatsky
2019-07-16 19:28 ` Keith David Bershatsky
2019-07-23 6:01 ` Keith David Bershatsky
2019-08-23 5:19 ` Keith David Bershatsky
2019-10-17 21:08 ` bug#22873: #22873 (multiple fake cursors); and, #17684 (crosshairs / fill-column) Keith David Bershatsky
2020-03-04 9:03 ` Keith David Bershatsky
-- strict thread matches above, loose matches on Subject: below --
2014-06-03 20:36 bug#17684: 24.4.50; Feature Request -- Vertical Lines to the Left of and Through Characters Keith David Bershatsky
2018-07-09 5:28 ` bug#17684: #22873 (multiple fake cursors); and, #17684 (crosshairs) Keith David Bershatsky
2018-11-11 3:36 ` Keith David Bershatsky
2018-11-11 16:51 ` Keith David Bershatsky
2018-11-21 4:53 ` bug#17684: #22873 (multiple fake cursors); and, #17684 (crosshairs / fill-column) Keith David Bershatsky
2018-12-14 7:11 ` Keith David Bershatsky
2019-04-09 4:03 ` bug#17684: #22873 (multiple fake cursors); and, #17684 (crosshairs) Keith David Bershatsky
2019-04-21 5:15 ` Keith David Bershatsky
2019-04-29 1:21 ` Keith David Bershatsky
2019-06-08 23:44 ` Keith David Bershatsky
2019-06-16 8:07 ` Keith David Bershatsky
2019-06-24 2:25 ` Keith David Bershatsky
2019-06-30 5:42 ` Keith David Bershatsky
2019-07-31 19:39 ` Keith David Bershatsky
2019-10-18 1:12 ` bug#17684: #22873 (multiple fake cursors); and, #17684 (crosshairs / fill-column) Keith David Bershatsky
2019-11-18 6:58 ` Keith David Bershatsky
2020-01-27 7:39 ` Keith David Bershatsky
2020-05-02 20:50 ` Keith David Bershatsky
2020-10-01 3:00 ` bug#17684: bug#22873: " Lars Ingebrigtsen
2020-10-01 3:54 ` Keith David Bershatsky
2020-10-01 16:21 ` Lars Ingebrigtsen
2020-10-01 17:00 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vb45ureq.wl%esq@lawlist.com \
--to=esq@lawlist.com \
--cc=22873@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jwiegley@gmail.com \
--cc=mbork@mbork.pl \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.