Re: [Emacs-diffs] emacs-25 4d8fd9c 4/4: Handle "empty line" regexp in xref searches

Re: [Emacs-diffs] emacs-25 4d8fd9c 4/4: Handle "empty line" regexp in xref searches

[John Wiegley]

>>>>> Dmitry Gutov <dgutov@yandex.ru> writes:

> branch: emacs-25
> commit 4d8fd9cf338cf9b5dfc613657adfeabff2d9c14e
> Author: Dmitry Gutov <dgutov@yandex.ru>
> Commit: Dmitry Gutov <dgutov@yandex.ru>

>     * lisp/progmodes/xref.el (xref--collect-matches-1): Stop after one
>     match if re-search-forward doesn't move point (bug#23426).

Hi Dmitry,

Was this issue on our blocking list? Should it have been?

We're now freezing beyond the point of ordinary fixes, so while you're free to
commit to 'master' and mark them for inclusion in 25.2, we're locking down on
what is accepted in emacs-25.

Thanks,
-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: [Emacs-diffs] emacs-25 4d8fd9c 4/4: Handle "empty line" regexp in xref searches

[Dmitry Gutov]

Hi John,

On 05/04/2016 02:08 AM, John Wiegley wrote:

>> branch: emacs-25
>> commit 4d8fd9cf338cf9b5dfc613657adfeabff2d9c14e
>> Author: Dmitry Gutov <dgutov@yandex.ru>
>> Commit: Dmitry Gutov <dgutov@yandex.ru>
>
>>     * lisp/progmodes/xref.el (xref--collect-matches-1): Stop after one
>>     match if re-search-forward doesn't move point (bug#23426).

> Was this issue on our blocking list?

Apparently not.

> Should it have been?

I believe so, yes. But if Eli thinks otherwise, feel free to revert it.

There was another, considerably less critical, but also less risky 
change in the same push (6f82d8e). If anything, I expected that one to 
spark some discussion. It's straight up performance improvement, however.

Again, feel free to revert in on emacs-25. Then I'll avoid making 
similar changes there.

Re: [Emacs-diffs] emacs-25 4d8fd9c 4/4: Handle "empty line" regexp in xref searches

[Eli Zaretskii]

> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Wed, 4 May 2016 02:18:30 +0300
> 
> > Was this issue on our blocking list?
> 
> Apparently not.

Btw, I believe it's high time Someone should go over the blocking
issues and remove any that we don't intend to fix before the release.

> > Should it have been?
> 
> I believe so, yes. But if Eli thinks otherwise, feel free to revert it.

No, I don't think otherwise.  Emacs that freezes is a bad bug that
cannot be left in the release, IMO.