From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#30343: make transpose-regions interactive Date: Sun, 11 Mar 2018 12:11:19 +0100 Message-ID: References: <83h8qp2jsg.fsf@gnu.org> <83zi3gt9za.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1520765894 14118 195.159.176.226 (11 Mar 2018 10:58:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 11 Mar 2018 10:58:14 +0000 (UTC) Cc: 30343-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 11 11:58:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euyg5-0003ZL-Kc for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Mar 2018 11:58:09 +0100 Original-Received: from localhost ([::1]:53782 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euyi8-00028M-Bo for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Mar 2018 07:00:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euyhz-00023N-4Q for bug-gnu-emacs@gnu.org; Sun, 11 Mar 2018 07:00:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euyhv-0000ne-9G for bug-gnu-emacs@gnu.org; Sun, 11 Mar 2018 07:00:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46806) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1euyhv-0000nH-5j for bug-gnu-emacs@gnu.org; Sun, 11 Mar 2018 07:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1euyhu-0000jv-V8 for bug-gnu-emacs@gnu.org; Sun, 11 Mar 2018 07:00:02 -0400 Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Mar 2018 11:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 30343 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 30343@debbugs.gnu.org, charles@aurox.ch, charles@aurox.ch Original-Received: via spool by 30343-done@debbugs.gnu.org id=D30343.15207659992799 (code D ref 30343); Sun, 11 Mar 2018 11:00:02 +0000 Original-Received: (at 30343-done) by debbugs.gnu.org; 11 Mar 2018 10:59:59 +0000 Original-Received: from localhost ([127.0.0.1]:54701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euyhr-0000j5-J9 for submit@debbugs.gnu.org; Sun, 11 Mar 2018 06:59:59 -0400 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:56391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euyhq-0000ip-Hq for 30343-done@debbugs.gnu.org; Sun, 11 Mar 2018 06:59:59 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 65ACF226C8 for <30343-done@debbugs.gnu.org>; Sun, 11 Mar 2018 11:00:32 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1520766030; x=1521630031; bh=5Qmos6Gb4wYhe OEsxodUDaNLtfBSeyaE09u1EpmJZ9M=; b=vxAqmV8yyj0qwrqqtqr3/NNrCLXhQ 4xnamRxfop0hCfXE8bH/L0fWbPZVQs5BZ9UR3aFPGdjGgtU9Gr2OGOaRaVpTj5Xv /SWLnBqXe5g2EvaNKp2oiQfA7pY+ZyD18YTGvm1rlqmbTJVSSGFZkobQNhaoVa5c fhYcJY3acWtJDY= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id q5YOd77L96EH for <30343-done@debbugs.gnu.org>; Sun, 11 Mar 2018 11:00:30 +0000 (UTC) Original-Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 58749226B0; Sun, 11 Mar 2018 11:00:30 +0000 (UTC) In-reply-to: <83zi3gt9za.fsf@gnu.org> (message from Eli Zaretskii on Sat, 10 Mar 2018 14:02:01 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144123 Archived-At: > Date: Sat, 10 Mar 2018 14:02:01 +0200 > From: Eli Zaretskii > CC: 30343@debbugs.gnu.org > Reply-to: Eli Zaretskii > > This LGTM, thanks. One minor comment: > > > +Interactively, STARTR1 and ENDR1 are point and mark; STARTR2 and ENDR2 > > +are the last two marks pushed to the mark ring; LEAVE-MARKERS is nil. > > +If a prefix argument N is given, STARTR2 and ENDR2 are the two > > +successive marks N entries backwards in the mark ring. A negative > > +prefix argument instead counts forwards from the oldest mark in the > > Please use "back" in "forward" here, instead of "backwards" and > "forwards". ("Backwards" has a meaning that might confuse readers > here.) Thanks again for the review, it's pushed now with your doc fix. commit b88e7c8bcd523f1f503f87a1734679405322b5ec Date: Sun Mar 11 11:59:01 2018 +0100 Make transpose-regions interactive (Bug#30343) * doc/emacs/fixit.texi (Transpose): Mention and explain the new command. * editfns.c (Ftranspose_regions): Add an interactive calling specification, and add documentation for it.