From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.bugs Subject: bug#33154: 27.0.50; create_process on Darwin should not invoke setsid() after vfork() [PATCH] Date: Wed, 07 Nov 2018 04:35:24 +0300 Message-ID: References: <20181026111227.GA48441@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1541554457 21259 195.159.176.226 (7 Nov 2018 01:34:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 7 Nov 2018 01:34:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) To: 33154@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 07 02:34:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKCjT-0005Qv-EE for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Nov 2018 02:34:11 +0100 Original-Received: from localhost ([::1]:45183 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKClZ-0001E1-S1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Nov 2018 20:36:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKClP-0001DO-1K for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 20:36:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKClK-0003XH-Fi for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 20:36:10 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33733) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKClG-00038u-T6 for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 20:36:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gKClG-0000gz-FB for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 20:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Filipp Gunbin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Nov 2018 01:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33154-submit@debbugs.gnu.org id=B33154.15415545352628 (code B ref 33154); Wed, 07 Nov 2018 01:36:02 +0000 Original-Received: (at 33154) by debbugs.gnu.org; 7 Nov 2018 01:35:35 +0000 Original-Received: from localhost ([127.0.0.1]:37991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKCko-0000gJ-N3 for submit@debbugs.gnu.org; Tue, 06 Nov 2018 20:35:34 -0500 Original-Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:41767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKCkn-0000g6-5s for 33154@debbugs.gnu.org; Tue, 06 Nov 2018 20:35:33 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4D962E93 for <33154@debbugs.gnu.org>; Tue, 6 Nov 2018 20:35:27 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 06 Nov 2018 20:35:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=OIu9LMd+BljzkCF+YyRfXPKhrm jLByCqd9HkRdLOta4=; b=p7MmbziznYUwIPW040TCKCdJKKiGcGNVEf2gsqXJ6V OmrWiilhaCm+uKdYT0xjNR7ImmjMztuCxv5y8zz3KwyvTB2P15YTCT84F0wp4GpA RYtFKN5rpVt9461n1VDRW1qD69Zwk1YWY5CW43LZg9sUdR7Fvq1eX3mI9hnCsQpM 4lNy4+WkCRCgvUq1lyy/7D618uk5Bt6LUnNihmLERudIVc9KjPZbhAs+bj24M/1s MDsFC35Aj4MggDH9ZcJVnlpNLqRhH4oX4BrWXSYolHL1twBRBKBMSre0+uZ0SYdm I+wYiOsPXor4PJi7Swyjw3SgmrKXlL4jyRHdJjprfxfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=OIu9LM d+BljzkCF+YyRfXPKhrmjLByCqd9HkRdLOta4=; b=kYFYHGXMH/DCxl7S4PxIPJ qOVlfqm1815OLpBGzl50iGtzOweElMBhiVvqlcoWI3268yNvtyIbY1YKNwbUvdrE rDUZDjOEKLhE4w8CE5uEU5IOIrejzKIW7QsVWZurBemkm0AT6hRSI2pTwXwkBWmp o3O23J8JmOX7R6gJZBCQBW78RcAYK+JRLwrIReRcZuJfY0TQzzvChzB6kxtVKjsV eAN4QpxbRWzTxSEFsb+JQ3MrQJOYx8RnXg4F7PfheJGmeij8OtO6xvjQrC3N4jPT Mm5q2C7j/Vr9pQcc4pf1SFsMq89PE0KBHFMJjgUCHUK9lqg5h/jTca4U8axuM64g == X-ME-Sender: X-ME-Proxy: Original-Received: from fgunbin.local (unknown [93.185.27.39]) by mail.messagingengine.com (Postfix) with ESMTPA id 17E42102DE for <33154@debbugs.gnu.org>; Tue, 6 Nov 2018 20:35:25 -0500 (EST) In-Reply-To: <20181026111227.GA48441@breton.holly.idiocy.org> (Alan Third's message of "Fri, 26 Oct 2018 12:12:27 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152117 Archived-At: Well, my initial patch fixed the pipe case, but broke the pty case. That became visible after make bootstrap. This new patch seems to work. It attempts to handle all cases: - When not on Darwin, just do vfork() and setsid() - When on Darwin and pipe mode, do the same as call_process(): vfork(), then detach from the current controlling terminal via TIOCNOTTY - When on Darwin and pty mode, do fork() and later setsid(). We should create new session to be able to use just allocated tty. I'll use it for some time, then report the result. Filipp diff --git a/src/process.c b/src/process.c index 6cda4f27ac..9125936eb9 100644 --- a/src/process.c +++ b/src/process.c @@ -2099,7 +2099,23 @@ create_process (Lisp_Object process, char **new_argv, Lisp_Object current_dir) #ifdef HAVE_PTYS /* First, disconnect its current controlling terminal. Do this even if !PTY_FLAG; see Bug#30762. */ +#ifdef DARWIN_OS + /* Darwin doesn't let us run setsid after a vfork, so use + TIOCNOTTY when necessary. */ + if (pty_flag) + setsid (); + else + { + int j = emacs_open (DEV_TTY, O_RDWR, 0); + if (j >= 0) + { + ioctl (j, TIOCNOTTY, 0); + emacs_close (j); + } + } +#else setsid (); +#endif /* Make the pty's terminal the controlling terminal. */ if (pty_flag && forkin >= 0) {