From: Keith David Bershatsky <esq@lawlist.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: xnrealloc: How and when to properly use it.
Date: Sat, 27 Apr 2019 21:50:17 -0700 [thread overview]
Message-ID: <m2v9yy20om.wl%esq@lawlist.com> (raw)
Thank you, Paul, for reviewing and responding to this particular thread.
Based upon your suggestion, I set w->mc_elts.caches = xnrealloc ... and have thus far been unable to crash Emacs -- i.e., your suggestion appears to have resolved the issue. I'll do some additional testing tomorrow and report back.
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
> Date: [04-27-2019 18:51:51] <27 Apr 2019 18:51:51 -0700>
> From: Paul Eggert <eggert@cs.ucla.edu>
> To: Keith David Bershatsky <esq@lawlist.com>
> Cc: Emacs Devel <emacs-devel@gnu.org>
> Subject: Re: xnrealloc: How and when to properly use it.
>
> Keith David Bershatsky wrote:
> > On a W32 build of Emacs (built with MinGW_32 and ezwinports downloaded a few years ago), my usage of xnrealloc (more often than not) causes Emacs to crash when_not_ running under gdb.
>
> Try the GDB command 'set disable-randomization off'. Of course this makes
> debugging more ... interesting.
>
> + /* Decrease the size of the array to a bare minimum. */
> + xnrealloc (w->mc_elts.caches, 1, sizeof *w->mc_elts.caches);
>
> That can't be right; at the very least you need to assign the returned value of xnrealloc back to w->mc_elts.caches.
next reply other threads:[~2019-04-28 4:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 4:50 Keith David Bershatsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-04-28 20:43 xnrealloc: How and when to properly use it Keith David Bershatsky
2019-04-28 0:26 Keith David Bershatsky
2019-04-28 1:51 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2v9yy20om.wl%esq@lawlist.com \
--to=esq@lawlist.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.