all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: emacs-devel@gnu.org
Subject: Re: search-default-mode char-fold-to-regexp and Greek Extended block characters
Date: Mon, 29 Jul 2019 10:32:58 +0200	[thread overview]
Message-ID: <m2v9vlme9x.fsf_-_@gmail.com> (raw)
In-Reply-To: <878sskybpi.fsf@mail.linkov.net> (Juri Linkov's message of "Fri,  26 Jul 2019 21:38:30 +0300")

>>>>> On Fri, 26 Jul 2019 21:38:30 +0300, Juri Linkov <juri@linkov.net> said:

    Juri> If there are many such cases, then better to handle them automatically indeed
    Juri> (if this doesn't cause slowdown too much) instead of adding them one by one
    Juri> to the default values.  Does this handle ß as well?
    >> 
    >> There are 74, and I donʼt want to maintain such a list by hand :-).

    Juri> Yes, 74 is too tedious to maintain by hand, so better to install your
    Juri> previous patch (if it doesn't have the problem mentioned below) since

The only difference between v2 and v1 of the patch is that v2 handles
ß, so v1 is probably better.

    Juri> there are only 3 such complex characters (handled by your newer patch)
    Juri> that is easy to add by hand:

    Juri>   '((?ß "ss")
    Juri>     (?ΐ "ΐ")
    Juri>     (?ΰ "ΰ"))

I donʼt understand this comment. With v1 of the patch, ß is the only
one that would need to be added by hand to char-fold--default-include

    >> ß is not a complex character, so is never looked at here. But if we
    >> hoist the checking out of the loop over complex characters, we can
    >> make that work as well (this supersedes my previous patch).
    >> 
    >> I have no idea of the performance impact of all this.
    >> [...]
    >> +                   (aset equiv (aref roundtrip 0)
    >> +                         (cons str (aref equiv (aref roundtrip 0))))))

    Juri> It seems this adds a symmetric decomposition from the first character of "ss",
    Juri> i.e. from ?s to "ß".  Shouldn't this rather update 'equiv-multi' instead?

Yes, thinko on my part.

    Juri> OTOH, I see no reason to add symmetric decompositions by default since
    Juri> they are handled by the option 'char-fold-symmetric'.

OK. Sounds like v1 is the winner. Iʼll clean it up and commit when ready.

Robert



  reply	other threads:[~2019-07-29  8:32 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-19 14:18 search-default-mode char-fold-to-regexp and Greek Extended block characters Robert Pluim
2019-07-19 14:37 ` Eli Zaretskii
2019-07-19 16:03   ` Robert Pluim
2019-07-19 18:13     ` Eli Zaretskii
2019-07-21 11:03       ` Robert Pluim
2019-07-22 18:39         ` Robert Pluim
2019-07-23 14:57           ` Eli Zaretskii
2019-07-23 17:43             ` Robert Pluim
2019-07-23 20:29               ` Juri Linkov
2019-07-24  7:56                 ` Robert Pluim
2019-07-24  7:59                   ` Robert Pluim
2019-07-24  9:04                 ` Robert Pluim
2019-07-24 23:12                   ` Juri Linkov
2019-07-25  0:18                     ` Basil L. Contovounesios
2019-07-25 18:40                       ` Juri Linkov
2019-07-25 20:44                         ` search-default-mode char-fold-to-regexp and Greek Extended block characters, " Robert Pluim
2019-07-25 21:35                           ` Juri Linkov
2019-07-26 11:09                             ` Robert Pluim
2019-07-26 18:38                               ` Juri Linkov
2019-07-29  8:32                                 ` Robert Pluim [this message]
2019-07-29 18:09                                   ` Juri Linkov
2019-07-30  8:09                                     ` Robert Pluim
2019-07-30 10:15                                       ` Eli Zaretskii
2019-07-25  2:36                     ` Eli Zaretskii
2019-07-25  8:59                       ` Robert Pluim
2019-07-25 12:53                         ` Eli Zaretskii
2019-07-25  8:46                     ` Robert Pluim
2019-07-25 18:46                       ` Juri Linkov
2019-07-26  6:04                         ` Eli Zaretskii
2019-07-26 18:40                           ` Juri Linkov
2019-07-26 19:13                             ` Eli Zaretskii
2019-07-19 18:53 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2v9vlme9x.fsf_-_@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.