From: Filipp Gunbin <fgunbin@fastmail.fm>
To: emacs-devel@gnu.org
Subject: Review request (compilation-error-regexp-alist-alist)
Date: Mon, 28 Oct 2019 23:50:59 +0300 [thread overview]
Message-ID: <m2v9s8k30s.fsf@fastmail.fm> (raw)
Hi, could you please review this to check I haven't done anything
obviously wrong?
Thanks.
Filipp
diff --git a/etc/compilation.txt b/etc/compilation.txt
index 0e39ab5e4a..4a4a318d03 100644
--- a/etc/compilation.txt
+++ b/etc/compilation.txt
@@ -185,6 +185,14 @@ Warning near line 10 file arrayclash.f: Module contains no executable
Nonportable usage near line 31 col 9 file assign.f: mixed default and explicit
+* Gradle with kotlin-gradle-plugin
+
+symbol: gradle-kotlin
+
+e: /src/Test.kt: (34, 15): foo: bar
+w: /src/Test.kt: (34, 15): foo: bar
+
+
* IAR Systems C Compiler
symbol: iar
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index cd7a5dc677..24c8a2a312 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -236,6 +236,15 @@ compilation-error-regexp-alist-alist
"\\(^Warning .*\\)? line[ \n]\\([0-9]+\\)[ \n]\\(?:col \\([0-9]+\\)[ \n]\\)?file \\([^ :;\n]+\\)"
4 2 3 (1))
+ ;; Gradle with kotlin-gradle-plugin (see
+ ;; GradleStyleMessagerRenderer.kt in kotlin sources).
+ (gradle-kotlin
+ ,(concat
+ "^\\(?:\\(w\\)\\|.\\): *" ;type
+ "\\(\\(?:[A-Za-z]:\\)?[^:\n]+\\): *" ;file
+ "(\\([0-9]+\\), *\\([0-9]+\\))") ;line, column
+ 2 3 4 (1))
+
(iar
"^\"\\(.*\\)\",\\([0-9]+\\)\\s-+\\(?:Error\\|Warnin\\(g\\)\\)\\[[0-9]+\\]:"
1 2 nil (3))
diff --git a/test/lisp/progmodes/compile-tests.el b/test/lisp/progmodes/compile-tests.el
index 08a369e7b5..e38c31dd0a 100644
--- a/test/lisp/progmodes/compile-tests.el
+++ b/test/lisp/progmodes/compile-tests.el
@@ -212,6 +212,13 @@ compile-tests--test-regexps-data
1 nil 27041 "{standard input}")
("boost/container/detail/flat_tree.hpp:589:25: [ skipping 5 instantiation contexts, use -ftemplate-backtrace-limit=0 to disable ]"
1 25 589 "boost/container/detail/flat_tree.hpp" 0)
+ ;; gradle-kotlin
+ ("e: /src/Test.kt: (34, 15): foo: bar" 4 15 34 "/src/Test.kt" 2)
+ ("w: /src/Test.kt: (11, 98): foo: bar" 4 98 11 "/src/Test.kt" 1)
+ ("e: e:/cygwin/src/Test.kt: (34, 15): foo: bar" 4 15 34 "e:/cygwin/src/Test.kt" 2)
+ ("w: e:/cygwin/src/Test.kt: (11, 98): foo: bar" 4 98 11 "e:/cygwin/src/Test.kt" 1)
+ ("e: e:\\src\\Test.kt: (34, 15): foo: bar" 4 15 34 "e:\\src\\Test.kt" 2)
+ ("w: e:\\src\\Test.kt: (11, 98): foo: bar" 4 98 11 "e:\\src\\Test.kt" 1)
;; Guile
("In foo.scm:\n" 1 nil nil "foo.scm")
(" 63:4 [call-with-prompt prompt0 ...]" 1 4 63 nil)
@@ -413,8 +420,8 @@ compile--test-error-line
(compilation-num-warnings-found 0)
(compilation-num-infos-found 0))
(mapc #'compile--test-error-line compile-tests--test-regexps-data)
- (should (eq compilation-num-errors-found 87))
- (should (eq compilation-num-warnings-found 32))
+ (should (eq compilation-num-errors-found 90))
+ (should (eq compilation-num-warnings-found 35))
(should (eq compilation-num-infos-found 26)))))
(ert-deftest compile-test-grep-regexps ()
next reply other threads:[~2019-10-28 20:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 20:50 Filipp Gunbin [this message]
2019-10-28 21:43 ` Review request (compilation-error-regexp-alist-alist) Stefan Monnier
2019-10-28 23:33 ` Filipp Gunbin
2019-10-29 1:13 ` Stefan Monnier
2019-10-29 2:01 ` Filipp Gunbin
2019-10-29 13:17 ` Stefan Monnier
2019-10-29 14:21 ` Filipp Gunbin
2019-10-29 14:51 ` Stefan Monnier
2019-10-29 16:42 ` Filipp Gunbin
2019-10-29 17:14 ` Stefan Monnier
2019-10-29 20:08 ` Filipp Gunbin
2019-10-31 18:28 ` Filipp Gunbin
2019-10-31 22:16 ` Stefan Monnier
2019-11-01 12:24 ` Filipp Gunbin
2019-10-31 2:07 ` Richard Stallman
2019-10-31 12:11 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2v9s8k30s.fsf@fastmail.fm \
--to=fgunbin@fastmail.fm \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.