From: Andrii Kolomoiets <andreyk.mad@gmail.com>
To: Pankaj Jangid <pankaj@codeisgreat.org>
Cc: 44420@debbugs.gnu.org
Subject: bug#44420: 28.0.50; vc-register, under vc-dir buffer, says file already registered
Date: Thu, 05 Nov 2020 10:05:29 +0200 [thread overview]
Message-ID: <m2v9ekkz3q.fsf@gmail.com> (raw)
In-Reply-To: <m2d00uqpjb.fsf@codeisgreat.org> (Pankaj Jangid's message of "Tue, 03 Nov 2020 23:41:04 +0530")
Pankaj Jangid <pankaj@codeisgreat.org> writes:
> Andrii Kolomoiets <andreyk.mad@gmail.com> writes:
>
>> See docstring of the `vc-deduce-fileset`:
>>
>> If the current buffer is in `vc-dir' or Dired mode, FILESET is the
>> list of marked files, or the current directory if no files are
>> marked.
>
> Got it. But the second clause `or the current directory if no files are
> marked' is not accurate. Because in that case `i' (vc-register) works if
> the point is on an untracked item.
Indeed.
> Wait... is `vc-deduce-fileset' relevant for `vc-register'? I don't
> know.
Yes. `vc-register` is calling `vc-deduce-fileset` right after `interactive`.
>> Including file name in the "File already registered" message may help to
>> understand whats going on though.
>
> This could be a long list. We can just say "Marked file(s) already
> registered".
Files in the list are checked one by one and error is returned for the
first registered file. IMO filename will fit well in the error message.
next prev parent reply other threads:[~2020-11-05 8:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 15:51 bug#44420: 28.0.50; vc-register, under vc-dir buffer, says file already registered Pankaj Jangid
2020-11-03 17:42 ` Andrii Kolomoiets
2020-11-03 18:11 ` Pankaj Jangid
2020-11-05 8:05 ` Andrii Kolomoiets [this message]
2020-11-05 10:32 ` Pankaj Jangid
2020-11-08 2:25 ` Dmitry Gutov
2020-11-08 2:58 ` Pankaj Jangid
2020-11-08 12:11 ` Dmitry Gutov
2020-11-08 12:21 ` Andrii Kolomoiets
2020-11-08 12:29 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2v9ekkz3q.fsf@gmail.com \
--to=andreyk.mad@gmail.com \
--cc=44420@debbugs.gnu.org \
--cc=pankaj@codeisgreat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.