From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arash Esbati Newsgroups: gmane.emacs.devel Subject: Re: master 8163e0b20c9: Improve 'refill-mode' in Org buffers Date: Sat, 27 Jan 2024 10:32:00 +0100 Message-ID: References: <170634561249.8419.14120799276160131850@vcs2.savannah.gnu.org> <20240127085332.C6466C4068B@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18893"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 27 10:32:48 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rTf3P-0004hO-Eo for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Jan 2024 10:32:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTf2k-00079r-S5; Sat, 27 Jan 2024 04:32:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTf2i-00079Q-Kk for emacs-devel@gnu.org; Sat, 27 Jan 2024 04:32:04 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTf2i-0004JO-2K for emacs-devel@gnu.org; Sat, 27 Jan 2024 04:32:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=adBABEuUpGV4Sbj3RhZnMfeSUNCI4/5dOs+3N+YnN0g=; b=DTlfrgZCuUgucWv6btCM TEjxoqQgI3OMS4JEojCwI+G1DqLrTrB8OlhTzDgNfbcVqGprNHsRDNPzgD0LICDNB/ivlw7zq4Q+9 95tbczM6ut4RXZs6EUv4tIPTZhhW9Tzp2CCoQ/jN8He4Z+FbiIN76ezwp64vc7f3x1NfQBHMLueI3 ZboNq+mVsxSnpEhHypYNNdTk1OEciZd+J5ZVG5rGyD3Ibu7+LVjvrSs8XKpCHguFSr4e/jS0kVqUj UcbNmseT7XZepZrqf7qyP3Dyb406BRGSKZQXyickoZW/9VB2bCbUXowrf6+F/msYqczUHrQLYfkLE WXe9R2XlvV5tSg==; In-Reply-To: <20240127085332.C6466C4068B@vcs2.savannah.gnu.org> (Eli Zaretskii's message of "Sat, 27 Jan 2024 03:53:32 -0500 (EST)") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315472 Archived-At: Eli Zaretskii writes: > branch: master > commit 8163e0b20c97a8394225a7165a8ab361af09ec29 > Author: Eli Zaretskii > Commit: Eli Zaretskii > > Improve 'refill-mode' in Org buffers >=20=20=20=20=20 > * lisp/textmodes/refill.el (refill-fill-paragraph-at): Use > 'fill-forward-paragraph' instead of 'forward/backward-paragraph', > so that modes could customize the behavior. (Bug#68418) > --- > lisp/textmodes/refill.el | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lisp/textmodes/refill.el b/lisp/textmodes/refill.el > index bb6b6ebda0f..244c96b60df 100644 > --- a/lisp/textmodes/refill.el > +++ b/lisp/textmodes/refill.el > @@ -106,10 +106,10 @@ This is used to optimize refilling.") > ;; FIXME: forward-paragraph seems to disregard `use-hard-newlines', > ;; leading to excessive refilling and wrong choice of fill-prefix. > ;; might be a bug in my paragraphs.el. > - (forward-paragraph) > + (fill-forward-paragraph) The compiler says: In refill-fill-paragraph-at: textmodes/refill.el:109:6: Warning: =E2=80=98fill-forward-paragraph=E2=80= =99 called with 0 arguments, but requires 1 Best, Arash