From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: face-cache Date: Sun, 28 Apr 2024 08:53:14 +0200 Message-ID: References: <87r0eqaslt.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23564"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel missing value To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 28 08:53:47 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s0yPz-00061V-4q for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Apr 2024 08:53:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0yPd-00086K-4o; Sun, 28 Apr 2024 02:53:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0yPY-00085k-BI for emacs-devel@gnu.org; Sun, 28 Apr 2024 02:53:20 -0400 Original-Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s0yPX-00040v-05; Sun, 28 Apr 2024 02:53:20 -0400 Original-Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a58f1f36427so55847666b.3; Sat, 27 Apr 2024 23:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714287196; x=1714891996; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=TNfCykYAhYJRwY+5ZxEp1YvIgnfZSCcNx4HGyNCMWJw=; b=K+9GFu3DAbyQTmkFf3XwaejHZGXLEJ6348g2AHrsvG1FyMKa/LuhFvAacEkO5rCYrd AFjLzojbChZVqDxKkn9ADP6gxWz5YSlegabJBN9SyNUlm4zpsKSzvdzOQxljG5ZJs+2S BGm3shx0YPOjyYt8Nh1CRihs/tjK5P/nFIoosc2JN7BUU7Opgf9gdQMnoC9xbMIRHqgz WOLOQKAjyxojyl3P8e1yLSLeJYIhsngaw/PKeVgNuDTCsWLXYvzjwqXt1wEc2bM4ydvr BbuZuXywiBQ15mwtKGhYrmeVjAbNoOgN9a6OE6KJZ5TCga+We3DZgrBPYss310u7yApO /CJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714287196; x=1714891996; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TNfCykYAhYJRwY+5ZxEp1YvIgnfZSCcNx4HGyNCMWJw=; b=J+sHjqvBMayXMjHKoiIbeNNFI23bFJ/vNVsOiVcf1+5zqzf2ox3SXms4C45SJxWMc2 Zh+uWoBB/FkVdHRBrKnRo6HlYVD/Mxqvpcs9eZ2l0xhUqAyn4R7J8Hk3WKjbHyqVGYMm LkYuL3YUoJgeBBmmkGWiHzOcgn6QL+ahDtyRbX+7GJI1YA1QDzgTq+SlWrF4/BWLKFwE KYZvKPlitYEbEzLTf0v4dmcEsQ6MI5DUDKWre/Vdv/wqPPwOPcIEzOSvhYXqMb+8a5kq QBRRDJqjSR+S2u7+fSZ6vSRzbQBp3DwJOa8v8KAKDUvIKJ16M2z85M/wULUbAW94aPqR 9JvA== X-Forwarded-Encrypted: i=1; AJvYcCXWeLegY6DSdlWbsYQyrmQdXfLe/AECUR0WQ4O9moUTXhe3iBW2pZ8ggxlyeq584JBl0CtyRcbNMOzNwRN7e0rgNwOO X-Gm-Message-State: AOJu0YwokyS91QXRQU6upLUC/FRZyej3NzYG8oEjLcf9jm8mwGv48uTz qVfMJFkoXM92cSmdnP9uVMd3WUQtYf3w01Oaf2rnmiRbY4iHrH5aNQ2Ddg== X-Google-Smtp-Source: AGHT+IGKlKHMQM6GaQHG6fIAd1va8tSaZZ4MmAKv4pVF8RzFwGp5kkLsKFu6TIFS2C2e6UukJXm9cA== X-Received: by 2002:a17:906:389:b0:a58:789f:6060 with SMTP id b9-20020a170906038900b00a58789f6060mr4745478eja.46.1714287195840; Sat, 27 Apr 2024 23:53:15 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36a77.dip0.t-ipconnect.de. [217.227.106.119]) by smtp.gmail.com with ESMTPSA id bl18-20020a170906c25200b00a52295e014bsm12539607ejb.92.2024.04.27.23.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Apr 2024 23:53:15 -0700 (PDT) In-Reply-To: <87r0eqaslt.fsf@gmail.com> (Helmut Eller's message of "Sun, 28 Apr 2024 08:50:22 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318237 Archived-At: Helmut Eller writes: >> Did that now, but it's still crashing. My impression, which might of >> course be completely wrong, is that we are losing faces somehow, i.e. >> something is wrong with the cache. > > I think the problem is in realize_non_ascii_face. The xmalloc > should be replaced with igc_make_face. Wow! I'm an idiot. All three thumbs up! Did you already try it?