From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: John Wiegley Newsgroups: gmane.emacs.bugs Subject: bug#72993: 31.0.50; 4f521fa14c18f57e5207bffd68e9f79454dccc79 breaks binding mode hooks in use-package Date: Mon, 02 Sep 2024 21:37:54 -0700 Message-ID: References: <87mskpo5qc.fsf@stebalien.com> <86v7zd79ds.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40174"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 72993@debbugs.gnu.org, Steven Allen To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 03 06:39:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1slLK1-000AB5-AM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Sep 2024 06:39:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1slLJn-0003Bm-3c; Tue, 03 Sep 2024 00:39:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slLJm-0003Ba-3e for bug-gnu-emacs@gnu.org; Tue, 03 Sep 2024 00:39:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1slLJk-0001pe-KC for bug-gnu-emacs@gnu.org; Tue, 03 Sep 2024 00:39:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=8uUYusxcofstZWgqF5xK7P3ckQuuIZf7eHyxzYU+rEQ=; b=vzibeqp/GDlSxe+9O+bKTBwuUm4rekdw1/jnqbRzswfqKyrslgnXUmc5yJISZrknW29u52kia2vx+XF4xXLwgSdyjsoLWeFLYegNUvDCtJf8AfHgW4SDhxjMuFFqB7r3HrD95Wpzt+3UfynFvH/vsUssONZAwLDkwj+4iihS3za2Fr0fUB3lEWDkwvje/lpmXl2rJ/jGxozm1t0nTM538JiSGVjlBhl1Lm4L9hQNTA4Co7qPrfM4V2n5WLqdx5+PEbKztR1eZ+pnAfY8qwagjjJflVjdCyNC6ipwKxjbjHK6i/l2g+E30XhTvbgNZWeUgLc0dyAyCns6d+s9UGWxDA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1slLKk-00042T-AT for bug-gnu-emacs@gnu.org; Tue, 03 Sep 2024 00:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: John Wiegley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Sep 2024 04:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72993 X-GNU-PR-Package: emacs Original-Received: via spool by 72993-submit@debbugs.gnu.org id=B72993.172533834915437 (code B ref 72993); Tue, 03 Sep 2024 04:40:02 +0000 Original-Received: (at 72993) by debbugs.gnu.org; 3 Sep 2024 04:39:09 +0000 Original-Received: from localhost ([127.0.0.1]:56231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slLJt-00040u-BI for submit@debbugs.gnu.org; Tue, 03 Sep 2024 00:39:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slLJq-00040S-TL for 72993@debbugs.gnu.org; Tue, 03 Sep 2024 00:39:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slLIl-0001mx-PO; Tue, 03 Sep 2024 00:37:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=8uUYusxcofstZWgqF5xK7P3ckQuuIZf7eHyxzYU+rEQ=; b=EEP9J62tNUzoT/or80Zn uZus9nxuSAgfGop0Ov39bUZ7jxyvUkYIdPqHhRweCcij7ujhgNkM+OFXM/ZqRN1MY4xnfZjXKdgXS tcdiJWicQr04iM0Zyz4Fs/0CrJ2epHrBJcDrHT4oLv1Mi0Tw9618T1nek++kcWJoJM9azoKPP86eB xMjslncXGX2pa1vdVughfWkBe/OacaukVFN3ce9NwmOi6u4Qz/Rc0CXI7qM+X7RPGvJSajBTMt3K8 R54IXn9axiqKxTgI31xE5Z+MeWr9W8DnETWMeKfl1BvOcRMvXXEwLGtGZ2q5GnOo40B6bo0jB+uRJ bLQZlMRwgTioUw==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudehgedgkeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkfgggtgfgsehtqhertddtreej necuhfhrohhmpeflohhhnhcuhghivghglhgvhicuoehjohhhnhifsehgnhhurdhorhhgqe enucggtffrrghtthgvrhhnpeeiffdthedviedvtdfffeffffevkeeludejieeltddufeeh fefhhfefgeejteefgeenucffohhmrghinhepnhgvfigrrhhtihhsrghnshdrtghomhenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhhnhif odhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeikeejkedtleeggedqudejje ehfeekudeiqdhjohhhnhifpeepghhnuhdrohhrghesnhgvfigrrhhtihhsrghnshdrtgho mhdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepje dvleelfeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehsthgvvhgvnhes shhtvggsrghlihgvnh X-ME-Proxy: Feedback-ID: ib64945b7:Fastmail In-Reply-To: <86v7zd79ds.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 03 Sep 2024 05:34:39 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291132 Archived-At: >>>>> Eli Zaretskii writes: >> To reproduce: >>=20 >> (use-package foo >> :hook (eshell-mode . some-function)) >>=20 >> Previously, `use-package' always appended `-hook' to the hook variable n= ame. >> After 4f521fa14c18f57e5207bffd68e9f79454dccc79, `use-package' only does >> so if the passed variable name isn't bound. Unfortunately, this breaks >> binding mode hooks, e.g.: >>=20 >> :hook (some-mode . some-function) >>=20 >> Because `some-mode' is usually bound. > John, any comments or suggestions? Sigh, I should have thought of this. There will be many such collisions, in fact. Perhaps we should avoid auto -hook=E2=80=99ifying the variable name only if= the name does not already end in =E2=80=98-functions=E2=80=99? What do you think, Eli? --=20 John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2