From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: [scratch/igc] 985247b6bee crash on Linux, KDE, Wayland Date: Thu, 05 Sep 2024 15:20:40 +0200 Message-ID: References: <8734mezkgo.fsf@gmail.com> <87plpis6ff.fsf@protonmail.com> <87bk124aip.fsf@gmail.com> <87h6aus5yz.fsf@protonmail.com> <87y1461frv.fsf@gmail.com> <864j6u47g4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="957"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eval EXEC , pipcet@protonmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 05 15:21:45 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smCQh-000Ads-Hc for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Sep 2024 15:21:43 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smCPq-0005WJ-5L; Thu, 05 Sep 2024 09:20:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smCPn-0005Lk-Eb for emacs-devel@gnu.org; Thu, 05 Sep 2024 09:20:47 -0400 Original-Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smCPl-0006Cx-EH; Thu, 05 Sep 2024 09:20:47 -0400 Original-Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a867a564911so102855366b.2; Thu, 05 Sep 2024 06:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725542443; x=1726147243; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ziB7TTMdEg7QPuqsfCPOy7tAxMKk8dndqE3tUx8dm10=; b=hophY7/m8MSBGnmNbj6VE4U2/XLBOFotZcsSQe2JHDI6bTj485RqhB3znUSnsC5dy8 PHYD0KzBcPWDrMNltt6jkMk3bb6jawm6ocJRWdZAa61UDr56pbGWKLs8mIje2FbY8+xE V2eFOp5lVl0Mulz5CdpG5fd1sAPVwk4eW22ZdH5qwavumjDYebOHpcy2pV1Hx8jMlxIQ SZckZ2RVjvckWQ06E2zr/kOQNND/UP2e2xENNosIxYAytzaC0PYEgjcRv8ZVEX+DrHwe xdSKdumifSIoe2qJVIiRh1NkLiBC3zfyE62c7YkQ2GxHqBszJ216x5EsJhSyca2+sX2k bIGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725542443; x=1726147243; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ziB7TTMdEg7QPuqsfCPOy7tAxMKk8dndqE3tUx8dm10=; b=tXyZg47njo5uqKZp310IsYypWb8wt9kVHU8YKRNVCUUlEyFDuE4Uf7ExP4Y692pomy fqOdnuoCEtES0l50Y8PxJun3NKYktJgTWmU2nv0RKW/ZHntUW64LO9Q2UHLzyN/+RugJ lWYrmvA0Chj9jP1UlX1oSXEA6TCXx7NxAUWLN8RijdA9c4Uz1II98RApGzCzmMvBpdAY 5yde4TG0NM7knHhzJFPVIWpbl2ADRlw3TiYoKtFwm2h0Wwej2wBi2GNh+351bEzzDFhx vn0643eOcDtdHkrPsFBFy0PumlGIyW/WV6Nphvoiq+1gGs+VyKMoGGeGH2qM7whO+2Kj Zruw== X-Forwarded-Encrypted: i=1; AJvYcCVAH7Sgcod8MnAEnHCL6y8Aqb57TNFdzsAsqeofnFYJHW0lRVzwhSoW8W1kSLJVnDbn+Tg/1vZdoR8UHQ==@gnu.org X-Gm-Message-State: AOJu0Yztpl4n35odcysVHMhFDlWA+/jFlvrJdytRE5leAg3GDPICUojO yfneZzs/mKjijaRptSzTmjPyIb57FPOrQM8lqh9pIaLb2ip+5bRLN60F/A== X-Google-Smtp-Source: AGHT+IHdDg0ypCBD9trvztAH9QKhE7O4S1uAip0cP/D80rqfv3ydkakZuqPqZkqpx6Sqk41XPEYjxw== X-Received: by 2002:a17:907:7f24:b0:a86:9690:9c10 with SMTP id a640c23a62f3a-a89b96f8b6emr1527104066b.49.1725542442369; Thu, 05 Sep 2024 06:20:42 -0700 (PDT) Original-Received: from pro2.fritz.box (p4fe3af05.dip0.t-ipconnect.de. [79.227.175.5]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8a6236d07esm134999066b.128.2024.09.05.06.20.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 06:20:41 -0700 (PDT) In-Reply-To: <864j6u47g4.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 Sep 2024 15:21:31 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323404 Archived-At: Eli Zaretskii writes: >> From: Eval EXEC >> Cc: emacs-devel >> Date: Thu, 05 Sep 2024 19:49:56 +0800 >> >> >> It crash again: >> [...] >> #19 0x00000000006d7a10 in deliver_thread_signal.constprop.0 (sig=11, handler=) at /home/exec/Projects/git.savannah.gnu.org/git/emacs/src/sysdep.c:1792 >> old_errno = >> #20 >> No symbol table info available. >> #21 0x00007f5fde45316b in kill () from /nix/store/dbcw19dshdwnxdv5q2g6wldj6syyvq7l-glibc-2.39-52/lib/libc.so.6 >> No symbol table info available. >> #22 0x0000000000767b69 in sigHandle () >> No symbol table info available. >> #23 >> No symbol table info available. >> #24 0x0000000000692cd8 in fix_frame (f=0x7f5f87885498, ss=0x7ffe0290f6a8) at /home/exec/Projects/git.savannah.gnu.org/git/emacs/src/igc.c:2068 > > This segfault is here: > > if (!FRAME_INITIAL_P (f)) > { > /* This is typically stored in the display_info, e.g. > ns_display_info. Check for being NULL anyway. */ > Mouse_HLInfo *hlinfo = MOUSE_HL_INFO (f); <<<<<<<<<<<<<<<<<<<<<<< > if (hlinfo) > { > IGC_FIX12_OBJ (ss, &hlinfo->mouse_face_window); > IGC_FIX12_OBJ (ss, &hlinfo->mouse_face_overlay); > IGC_FIX12_RAW (ss, &hlinfo->mouse_face_mouse_frame); > } > } > > This code was added just a few days ago. MOUSE_HL_INFO expands to: > > # define MOUSE_HL_INFO(F) \ > (FRAME_WINDOW_P (F) \ > ? &FRAME_DISPLAY_INFO(F)->mouse_highlight \ > : &(F)->output_data.tty->display_info->mouse_highlight) > > So this looks like FRAME_DISPLAY_INFO(F) is not traced or something? Hm, sesms we have to check for FRAME_OUTPUT_DATA being null for window frames. Sorry for that. I'll push a fix tomorrow unless someone beats me to it. Something like if (!FRAME_INITIAL_P (f) && (!FRAME_WINDOW_P (f) || FRAME_OUTPUT_DATA (f))) or something. Or maybe even nicer would be to let MOUES_HL_INFO return NULL if !FRAME_OUTPUT_DATA, but whatever.