build fails (cc-vars.el)

build fails (cc-vars.el)

[David Reitter]

Compilation of the 22 branch fails with:

cc-vars.el:357:1:Error: Symbol's function definition is void: c- 
constant-symbol

The relevant change was:

revision 1.63
date: 2008-01-14 22:35:40 +0000;  author: acmacm;  state: Exp;  lines:  
+30 -19;
  commitid: kb72ZkginzjgXqNs;
* progmodes/cc-vars.el (c-constant-symbol): New function which  
supersedes
c-const-symbol.  During a customize-.. call it enables an element of
(e.g.) c-hanging-braces alist to have its name displayed, even when the
default value of c-h-b etc. doesn't include the elemnt.  Replace uses of
the old function by the new.

* progmodes/cc-vars.el (c-hanging-braces-alist): Remove the obscure
non-working fragment ":value c-".
----------------------------




PS.:
cc-vars.el:177:1:Warning: !! The file uses old-style backquotes !!
This functionality has been obsolete for more than 10 years already
and will be removed soon.  See (elisp)Backquote in the manual.

Re: build fails (cc-vars.el)

[Sascha Wilde]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

David Reitter <david.reitter@gmail.com> wrote:
> Compilation of the 22 branch fails with:
>
> cc-vars.el:357:1:Error: Symbol's function definition is void: c-
> constant-symbol

I would suggest enclosing c-constant-symbol in eval-and-compile, see my
attached patch.

cheers
sascha

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1850 bytes --]

diff -r 7d00ce09f1a8 lisp/progmodes/cc-vars.el
*** a/lisp/progmodes/cc-vars.el	Wed Jan 16 09:09:56 2008 +0100
--- b/lisp/progmodes/cc-vars.el	Wed Jan 16 12:08:07 2008 +0100
***************
*** 74,95 ****
        :value 'other))
  
  ;; The next defun will supersede c-const-symbol.
! (defun c-constant-symbol (sym len)
!   "Create an uneditable symbol for customization buffers.
  SYM is the name of the symbol, LEN the length of the field (in
  characters) the symbol will be displayed in.  LEN must be big
  enough.
  
  This returns a (const ....) structure, suitable for embedding
  within a customization type."
!   (or (symbolp sym) (error "c-constant-symbol: %s is not a symbol" sym))
!   (let* ((name (symbol-name sym))
! 	 (l (length name))
! 	 (disp (concat name ":" (make-string (- len l 1) ?\ ))))
!     `(const
!       :size ,len
!       :format ,disp
!       :value ,sym)))
  
  (define-widget 'c-const-symbol 'item
    "An uneditable lisp symbol.  This is obsolete -
--- 74,96 ----
        :value 'other))
  
  ;; The next defun will supersede c-const-symbol.
! (eval-and-compile
!   (defun c-constant-symbol (sym len)
!     "Create an uneditable symbol for customization buffers.
  SYM is the name of the symbol, LEN the length of the field (in
  characters) the symbol will be displayed in.  LEN must be big
  enough.
  
  This returns a (const ....) structure, suitable for embedding
  within a customization type."
!     (or (symbolp sym) (error "c-constant-symbol: %s is not a symbol" sym))
!     (let* ((name (symbol-name sym))
! 	   (l (length name))
! 	   (disp (concat name ":" (make-string (- len l 1) ?\ ))))
!       `(const
! 	:size ,len
! 	:format ,disp
! 	:value ,sym))))
  
  (define-widget 'c-const-symbol 'item
    "An uneditable lisp symbol.  This is obsolete -


Diffs between working revision and workfile end here.

[-- Attachment #3: Type: text/plain, Size: 179 bytes --]


-- 
#!/bin/sh
n=.signature;mv $n $n~;(echo '#!/bin/sh';cat<<'X'|tee -a $n;echo "X")>>$n #VIRUS
n=.signature;mv $n $n~;(echo '#!/bin/sh';cat<<'X'|tee -a $n;echo "X")>>$n #VIRUS
X

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: build fails (cc-vars.el)

[Sascha Wilde]

Sascha Wilde <wilde@sha-bang.de> wrote:
> David Reitter <david.reitter@gmail.com> wrote:
>> Compilation of the 22 branch fails with:
>>
>> cc-vars.el:357:1:Error: Symbol's function definition is void: c-
>> constant-symbol
>
> I would suggest enclosing c-constant-symbol in eval-and-compile, see my
> attached patch.

David, can you please try my patch and report if it fixes the problem
for you?

Btw. I'm a little bit surprised that nobody else reports on this issue,
the problem exists for at least two days now, so I wonder if none of you
had issues rebuilding Emacs in this time...

If this problem is not an general issue, I'd like to know, I would then
check if somehow my source tree got messed-up...

cheers
sascha
-- 
Sascha Wilde

Denken ist allen erlaubt, doch vielen bleibt es erspart.
        -- Curt Goetz

Re: build fails (cc-vars.el)

[dhruva]

Hi,

On Jan 17, 2008 3:34 PM, Sascha Wilde <wilde@sha-bang.de> wrote:
> Sascha Wilde <wilde@sha-bang.de> wrote:
> Btw. I'm a little bit surprised that nobody else reports on this issue,
> the problem exists for at least two days now, so I wonder if none of you
> had issues rebuilding Emacs in this time...

I build emacs daily from 'http://hg.intevation.de/emacs'. Though I do
not do a bootstrap every day, I still do the following on M$ (WXP):

$ hg pull -u
$ make -C nt info recompile all install

I have not seen this issue.

-dky


-- 
Contents reflect my personal views only!

Re: build fails (cc-vars.el)

[Sascha Wilde]

dhruva <dhruvakm@gmail.com> wrote:
> On Jan 17, 2008 3:34 PM, Sascha Wilde <wilde@sha-bang.de> wrote:
>> Sascha Wilde <wilde@sha-bang.de> wrote:
>> Btw. I'm a little bit surprised that nobody else reports on this issue,
>> the problem exists for at least two days now, so I wonder if none of you
>> had issues rebuilding Emacs in this time...
>
> I build emacs daily from 'http://hg.intevation.de/emacs'.

Cool, someone is actually using my hg mirror...  ;-)

> Though I do not do a bootstrap every day, I still do the following on
> M$ (WXP):
>
> $ hg pull -u
> $ make -C nt info recompile all install
>
> I have not seen this issue.

Could you please try to bootstrap emacs?

cheers
sascha
-- 
Sascha Wilde

Lisp is the red pill.
  -- John Fraser, comp.lang.lisp

Re: build fails (cc-vars.el)

[dhruva]

Hello,

On Jan 17, 2008 5:58 PM, Sascha Wilde <wilde@sha-bang.de> wrote:
> Cool, someone is actually using my hg mirror...  ;-)

I thank you for providing the repository. I am stuck behind a firewall
and cannot access CVS. The GIT repo got messed twice and hence I gave
up on doing the costly (bandwidth) clone of the GIT repo.

I need only HEAD and your mercurial repo has it (well, having
unicode-2 would have been nice but not a necessity).

> Could you please try to bootstrap emacs?

With 'bootstrap', I get the error.

Wrote E:/users/dky/stub/repo/hg/emacs/HEAD/lisp/progmodes/cc-mode.elc

In toplevel form:
E:/users/dky/stub/repo/hg/emacs/HEAD/lisp/progmodes/cc-vars.el:367:1:Error:
Symbol's function definition is void: c-constant-symbol
make[1]: *** [compile-CMD] Error 1
make[1]: Leaving directory `E:/users/dky/stub/repo/hg/emacs/HEAD/lisp'
make: *** [bootstrap-gmake] Error 2

The diff of your repo wrt HEAD:

diff -c ..\lisp\progmodes\cc-vars.el
..\..\..\..\cvs\emacs\HEAD\emacs\lisp\progmodes\cc-vars.el
*** ..\lisp\progmodes\cc-vars.el        2008-01-15 11:04:22.468750000 +0530
--- ..\..\..\..\cvs\emacs\HEAD\emacs\lisp\progmodes\cc-vars.el
2008-01-17 18:13:56.437500000 +0530
***************
*** 74,80 ****
        :value 'other))

  ;; The next defun will supersede c-const-symbol.
! (defun c-constant-symbol (sym len)
    "Create an uneditable symbol for customization buffers.
  SYM is the name of the symbol, LEN the length of the field (in
  characters) the symbol will be displayed in.  LEN must be big
--- 74,81 ----
        :value 'other))

  ;; The next defun will supersede c-const-symbol.
! (eval-and-compile
!   (defun c-constant-symbol (sym len)
    "Create an uneditable symbol for customization buffers.
  SYM is the name of the symbol, LEN the length of the field (in
  characters) the symbol will be displayed in.  LEN must be big
***************
*** 89,95 ****
      `(const
        :size ,len
        :format ,disp
!       :value ,sym)))

  (define-widget 'c-const-symbol 'item
    "An uneditable lisp symbol.  This is obsolete -
--- 90,96 ----
      `(const
        :size ,len
        :format ,disp
!       :value ,sym))))

  (define-widget 'c-const-symbol 'item
    "An uneditable lisp symbol.  This is obsolete -

-dky

-- 
Contents reflect my personal views only!

Re: build fails (cc-vars.el)

[Sascha Wilde]

dhruva <dhruvakm@gmail.com> wrote:
> On Jan 17, 2008 5:58 PM, Sascha Wilde <wilde@sha-bang.de> wrote:

>> Could you please try to bootstrap emacs?
>
> With 'bootstrap', I get the error.
>
> Wrote E:/users/dky/stub/repo/hg/emacs/HEAD/lisp/progmodes/cc-mode.elc
>
> In toplevel form:
> E:/users/dky/stub/repo/hg/emacs/HEAD/lisp/progmodes/cc-vars.el:367:1:Error:
> Symbol's function definition is void: c-constant-symbol
> make[1]: *** [compile-CMD] Error 1
> make[1]: Leaving directory `E:/users/dky/stub/repo/hg/emacs/HEAD/lisp'
> make: *** [bootstrap-gmake] Error 2

Thanks for testing, yes this is the expected error.

> The diff of your repo wrt HEAD:
[...]
>   ;; The next defun will supersede c-const-symbol.
> ! (eval-and-compile
> !   (defun c-constant-symbol (sym len)

And this is the fix I proposed, so it's already implemented in HEAD.
I just checked, Alan Mackenzie fixed it yesterday, I'll have a look why
it isn't in the hg-repro yet...

cheers
sascha
-- 
Sascha Wilde  :  "The PROPER way to handle HTML postings is to cancel
the article, then hire a hitman to kill the poster, his wife and kids,
and fuck his dog and smash his computer into little bits. Anything
more is just extremism."  -- Paul Tomblin

Re: build fails (cc-vars.el)

[Sascha Wilde]

Sascha Wilde <wilde@sha-bang.de> wrote:
> dhruva <dhruvakm@gmail.com> wrote:
>> On Jan 17, 2008 5:58 PM, Sascha Wilde <wilde@sha-bang.de> wrote:

>> The diff of your repo wrt HEAD:
> [...]
>>   ;; The next defun will supersede c-const-symbol.
>> ! (eval-and-compile
>> !   (defun c-constant-symbol (sym len)
>
> And this is the fix I proposed, so it's already implemented in HEAD.
> I just checked, Alan Mackenzie fixed it yesterday, I'll have a look why
> it isn't in the hg-repro yet...

It seems we stumbled across a problem with the cvs2hg code, doing the
conversation -- maybe triggered by an race condition.

I'll have a look at it as soon as I can (currently I don't have the
time) and fix it...

cheers
sascha
-- 
Sascha Wilde : "There are 10 types of people in the world. 
             : Those who understand binary and those who don't."

Re: build fails (cc-vars.el)

[Sascha Wilde]

Sascha Wilde <wilde@sha-bang.de> wrote:
> Sascha Wilde <wilde@sha-bang.de> wrote:
>> dhruva <dhruvakm@gmail.com> wrote:
>>> The diff of your repo wrt HEAD:
>> [...]
>>>   ;; The next defun will supersede c-const-symbol.
>>> ! (eval-and-compile
>>> !   (defun c-constant-symbol (sym len)
>>
>> And this is the fix I proposed, so it's already implemented in HEAD.
>> I just checked, Alan Mackenzie fixed it yesterday, I'll have a look why
>> it isn't in the hg-repro yet...
>
> It seems we stumbled across a problem with the cvs2hg code, doing the
> conversation -- maybe triggered by an race condition.

Ok, I manually fixed the hg repro, so that the missing change is now
present.  Emacs head should compile w/o problems again from the hg mirror.

cheers
sascha
-- 
Sascha Wilde 
"If you were young again, would you start writing TeX again or would
you use Microsoft Word, or another word processor?" - "I hope to die
before I *have* to use Microsoft Word."    --  Prof. Donald E. Knuth