From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Wiegley Newsgroups: gmane.emacs.devel Subject: Re: Emacs bug #23794; sort-line behavior regressed from prior Emacs versions Date: Sun, 19 Jun 2016 11:16:18 -0700 Message-ID: References: <83shwa9zmr.fsf@gnu.org> <83lh229ywc.fsf@gnu.org> <83inx69xcx.fsf@gnu.org> <0984ce22-cbcf-42a6-906e-a03b65f3c71c@default> <8360t5aolu.fsf@gnu.org> <83vb158awq.fsf@gnu.org> <83oa6x87ky.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466360221 25866 80.91.229.3 (19 Jun 2016 18:17:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 19 Jun 2016 18:17:01 +0000 (UTC) Cc: rswgnu@gmail.com, rms@gnu.org, drew.adams@oracle.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 19 20:16:54 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bEhHB-0007uq-MJ for ged-emacs-devel@m.gmane.org; Sun, 19 Jun 2016 20:16:53 +0200 Original-Received: from localhost ([::1]:39648 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEhHA-0000im-N7 for ged-emacs-devel@m.gmane.org; Sun, 19 Jun 2016 14:16:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEhH4-0000iW-HC for emacs-devel@gnu.org; Sun, 19 Jun 2016 14:16:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEhH2-00053c-I9 for emacs-devel@gnu.org; Sun, 19 Jun 2016 14:16:45 -0400 Original-Received: from mail-pa0-x22e.google.com ([2607:f8b0:400e:c03::22e]:34580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEhGw-00052o-JZ; Sun, 19 Jun 2016 14:16:38 -0400 Original-Received: by mail-pa0-x22e.google.com with SMTP id bz2so43540302pad.1; Sun, 19 Jun 2016 11:16:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mail-followup-to:mime-version; bh=qeZy6zLGy2AGOvYV5tmNmUbxe9wlQMfwlMyJFC/YIBo=; b=j6AHm1p3yO58FoUBKP1y+3aipTZ1evJx+/7YKo6cbEGlnm+ILfvcpPT63yaZtkDa5P niXcpCeDwrWFBqK57iW4g8pZcCJoETd98X/RCqyTM2nod5Z/EsnKXz7OYWpZVex4b4d1 0u9Mug8L3noxQfrysOlAACnpKqD2i2c32QOz9DXfUDZoBlci+7G9T9aMG8YAKQcNhqL9 xV3bwBGm+gjyTt7pBHHdRvPug7yx1/q9oT9MWvqCkl53EhaLPy6vwdYzFI9fD86Vfezc kmZbLnXBkZZrwtP7w68sMSRwKV1EQmhFi1uARMbnuusYV8AhZhCdTlZeO/YaNIf0l6TE q55g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :references:user-agent:mail-followup-to:mime-version; bh=qeZy6zLGy2AGOvYV5tmNmUbxe9wlQMfwlMyJFC/YIBo=; b=VSdgvjtxClsDyiqxat9jwRUZjZbi71loruPkppEZ380/c0I4wuBwJYXig8qh8vZei/ pPweicnZ4Wch+ua8zb64aFrZzwnah4qGYorXIaDBzZZH9rtzMnyElabQX+bIyF+kBzYU bYsvq/bkwN/2ZaFNTkQ+MwJVuuiEdUjs4j/Qm8/S/HE0gyai2xOpMcSnOf/LvGmkG5bd 9u6aiP6xWBka+aT7WpeQJEvB1pk545Q6eucneU7c1x4TsES5O9PIK88ZSBqFPXfLFBOd yEUdLAKTn0nB+zFvU/8baYYUPZSQ5u7eBUZ7f7P2xK98Z2gqg8OwJYNs5nJrqkJoSjKp L3lg== X-Gm-Message-State: ALyK8tKPHkcdiWzLjKr2GCiUJWH658gMwwd1En1w/zXhqq+JmEeIEi+k4yhYiNw3rfoFOg== X-Received: by 10.66.246.198 with SMTP id xy6mr16795987pac.58.1466360197758; Sun, 19 Jun 2016 11:16:37 -0700 (PDT) Original-Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id x68sm17984205pfb.88.2016.06.19.11.16.36 (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 19 Jun 2016 11:16:36 -0700 (PDT) X-Google-Original-From: "John Wiegley" Original-Received: by Vulcan.local (Postfix, from userid 501) id 54B72997855; Sun, 19 Jun 2016 11:16:36 -0700 (PDT) In-Reply-To: <83oa6x87ky.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 19 Jun 2016 19:30:21 +0300") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.95 (darwin) Mail-Followup-To: Eli Zaretskii , rswgnu@gmail.com, rms@gnu.org, drew.adams@oracle.com, emacs-devel@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c03::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204537 Archived-At: >>>>> Eli Zaretskii writes: > Didn't think that far, but is it really clean for sort-lines to have special > code for some major mode? I thought a better way is to override the default > behavior by having sort-lines call functions through funcall or somesuch, > and then outline modes could set the appropriate variable to the function of > their liking? > > Just thinking aloud. I would prefer this approach as well. Rather than coupling core functionality to any particular mode, we should expose hooks that allow core functions to be specialized. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2