From: Alan Schmitt <alan.schmitt@polytechnique.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: completion discrepancy between default completion and helm/ivy completions
Date: Sun, 13 Nov 2016 14:05:08 +0100 [thread overview]
Message-ID: <m2twbb1qez.fsf@polytechnique.org> (raw)
In-Reply-To: <jwva8d7qdmv.fsf-monnier+gmane.emacs.devel@gnu.org> (Stefan Monnier's message of "Thu, 10 Nov 2016 15:35:41 -0500")
[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]
Hello Stefan,
On 2016-11-10 15:35, Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> (let ((completion (try-completion beforepoint table pred)))
>> (if (not (stringp completion))
>> completion
>
> This case is for when `completion` is t (when means that `beforepoint`
> is a valid candidate and there is no further completion possible).
I see.
>> I would like to fix org-contacts so that it works well all the time.
>> Should it directly return a cons of the string and its length?
>
> No, returning such a cons would be a bug and I'm pretty sure it would
> break the default completion code at least.
OK, but I do not know how to proceed then.
Is it correct to register as a completion something that returns a
string? Because it is what org-contacts does, but although it works with
the default completion code, it breaks ivy or helm style completions.
I'm trying to understand if the bug lies within org-contacts or within
iyv/helm.
Thanks,
Alan
--
OpenPGP Key ID : 040D0A3B4ED2E5C7
Monthly Athmospheric CO₂, Mauna Loa Obs. 2016-10: 401.57, 2015-10: 398.29
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]
next prev parent reply other threads:[~2016-11-13 13:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 11:22 completion discrepancy between default completion and helm/ivy completions Alan Schmitt
2016-11-10 20:35 ` Stefan Monnier
2016-11-13 13:05 ` Alan Schmitt [this message]
2016-11-13 15:38 ` Stefan Monnier
2016-11-14 13:22 ` Alan Schmitt
2016-11-14 14:20 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2twbb1qez.fsf@polytechnique.org \
--to=alan.schmitt@polytechnique.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.