From: Keith David Bershatsky <esq@lawlist.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 29002@debbugs.gnu.org
Subject: bug#29002: it.first_visible_x is erroneously 0 while horizontal scrolling.
Date: Sun, 05 Nov 2017 01:15:41 -0800 [thread overview]
Message-ID: <m2tvy9jdc2.wl%esq@lawlist.com> (raw)
In-Reply-To: <m2h8umbu0k.wl%esq@lawlist.com>
The new fix relating to #29002 has an unintended side-effect of causing a full redisplay too often, e.g., when using isearch.
I am uncertain why the current Emacs design sets w->suspend_auto_hscroll to *true* every command loop, but that is what causes the new condition to force a thorough redisplay much more often than is actually needed.
/* If the position of this window's point has explicitly
changed, no more suspend auto hscrolling. */
if (w->suspend_auto_hscroll
&& NILP (Fequal (Fwindow_point (window),
Fwindow_old_point (window))))
{
AUTO_STRING (my_string_one, "Hello world!");
CALLN (Fmessage, my_string_one);
w->suspend_auto_hscroll = false;
/* Force thorough redisplay of this window, to show the
effect of disabling hscroll suspension immediately. */
SET_FRAME_GARBAGED (XFRAME (w->frame));
}
next prev parent reply other threads:[~2017-11-05 9:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 1:03 bug#29002: it.first_visible_x is erroneously 0 while horizontal scrolling Keith David Bershatsky
2017-10-26 3:45 ` Keith David Bershatsky
2017-10-26 4:51 ` Eli Zaretskii
2017-10-26 6:20 ` Keith David Bershatsky
2017-10-26 15:56 ` Eli Zaretskii
2017-10-26 18:56 ` Keith David Bershatsky
2017-10-29 11:23 ` Eli Zaretskii
2017-10-29 17:29 ` Keith David Bershatsky
2017-10-29 18:29 ` Eli Zaretskii
2017-10-29 18:56 ` Eli Zaretskii
2017-10-29 18:56 ` Keith David Bershatsky
2017-10-29 19:23 ` Eli Zaretskii
2017-10-29 19:08 ` Keith David Bershatsky
2017-10-29 20:12 ` Keith David Bershatsky
2017-10-30 18:02 ` Eli Zaretskii
2017-10-30 19:36 ` Keith David Bershatsky
2017-11-04 9:32 ` Eli Zaretskii
2017-11-05 0:16 ` Keith David Bershatsky
2017-11-05 9:15 ` Keith David Bershatsky [this message]
2017-11-05 10:44 ` Eli Zaretskii
2017-11-05 16:59 ` Keith David Bershatsky
2017-11-05 18:12 ` Eli Zaretskii
2017-11-06 1:05 ` Keith David Bershatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2tvy9jdc2.wl%esq@lawlist.com \
--to=esq@lawlist.com \
--cc=29002@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.