From: Robert Pluim <rpluim@gmail.com>
To: Alex Gramiak <agrambot@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change
Date: Wed, 17 Apr 2019 10:24:47 +0200 [thread overview]
Message-ID: <m2tvexdoog.fsf@gmail.com> (raw)
In-Reply-To: <87zhopc1ia.fsf@gmail.com> (Alex Gramiak's message of "Tue, 16 Apr 2019 11:18:21 -0600")
>>>>> On Tue, 16 Apr 2019 11:18:21 -0600, Alex Gramiak <agrambot@gmail.com> said:
Alex> Robert Pluim <rpluim@gmail.com> writes:
>> CC xdisp.o xdisp.c:29300:37: error: no member named
>> 'x_highlight_frame' in 'struct ns_display_info'; did you mean
>> 'ns_highlight_frame'? || f != FRAME_DISPLAY_INFO
>> (f)->x_highlight_frame) ^~~~~~~~~~~~~~~~~ ns_highlight_frame
>> ./nsterm.h:884:17: note: 'ns_highlight_frame' declared here
>> struct frame *ns_highlight_frame; ^ 1 error generated.
>>
>> (on macOS)
Alex> Ah, I originally renamed the x_highlight_frame on W32/NS to
Alex> {w32,ns}_*, but decided against it since xdisp.c used the
Alex> attribute directly (a hook or union interface could be added
Alex> later). Perhaps it should be renamed native_highlight_frame
Alex> until then, though.
Alex> I pushed the fix, do you get any other errors/warnings on
Alex> macOS?
nsterm.m:2400:1: error: conflicting types for 'ns_query_color'
ns_query_color(void *col, XColor *color_def, bool setPixel)
^
./nsterm.h:1146:1: note: previous declaration is here
ns_query_color (void *col, XColor *color_def, int setPixel);
^
CC nsfns.o
nsfns.m:1389:4: warning: implicit declaration of function 'x_make_frame_visible'
is invalid in C99 [-Wimplicit-function-declaration]
x_make_frame_visible (f);
CC nsimage.o
nsimage.m:196:11: warning: implicit declaration of function 'x_find_image_file'
is invalid in C99 [-Wimplicit-function-declaration]
found = x_find_image_file (file);
^
nsimage.m:196:9: warning: incompatible integer to pointer conversion assigning
to 'Lisp_Object' (aka 'union Lisp_X *') from 'int' [-Wint-conversion]
found = x_find_image_file (file);
Robert
next prev parent reply other threads:[~2019-04-17 8:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190416165204.7024.23185@vcs0.savannah.gnu.org>
[not found] ` <20190416165207.442F52068F@vcs0.savannah.gnu.org>
2019-04-16 17:05 ` scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change Robert Pluim
2019-04-16 17:18 ` Alex Gramiak
2019-04-16 18:05 ` Eli Zaretskii
2019-04-17 14:15 ` Alex Gramiak
2019-04-17 8:24 ` Robert Pluim [this message]
2019-04-17 14:12 ` Alex Gramiak
2019-04-17 14:29 ` Robert Pluim
2019-04-17 14:40 ` Alex Gramiak
2019-04-17 14:59 ` Robert Pluim
2019-04-17 15:09 ` Robert Pluim
2019-04-17 15:39 ` Alex Gramiak
2019-04-17 15:46 ` Robert Pluim
2019-04-18 21:03 ` Alex Gramiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2tvexdoog.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=agrambot@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.