From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master ab36b56 1/2: ; * src/font.h (font_is_ignored): Add prototype to avoid warnings. Date: Thu, 14 Nov 2019 15:41:52 +0100 Message-ID: References: <20191114115158.1987.26946@vcs0.savannah.gnu.org> <20191114115159.EC9F020BC2@vcs0.savannah.gnu.org> <83d0du5ye1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="40530"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 14 15:42:22 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVGKE-000ARL-Hp for ged-emacs-devel@m.gmane.org; Thu, 14 Nov 2019 15:42:22 +0100 Original-Received: from localhost ([::1]:58306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVGKC-0004bV-1R for ged-emacs-devel@m.gmane.org; Thu, 14 Nov 2019 09:42:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51524) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVGJr-0004bL-3j for emacs-devel@gnu.org; Thu, 14 Nov 2019 09:42:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVGJo-0002ob-GN for emacs-devel@gnu.org; Thu, 14 Nov 2019 09:41:59 -0500 Original-Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:39089) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVGJo-0002mf-3k; Thu, 14 Nov 2019 09:41:56 -0500 Original-Received: by mail-wr1-x42e.google.com with SMTP id l7so6755046wrp.6; Thu, 14 Nov 2019 06:41:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=0KCnBU9YbtU8AU9N4VQqVJeJx/wZf55o7MkWmg9f/vo=; b=Dynz/GhikrRXWTp2v4sTbde9Lorb/ByqQ90HimlQ7466hRtr5NHWr1AN1KFvuf4hgQ DiEMcc3ZCjmVi1ZVQM8aiKaYJdaIz08082akZfeeAT3LXD47ftYrt6W1ixhQ24q8sKLX iZRvzq1yEsFXns3uXntvgifDR+R1/Rfr+DtCLh777d14gxzFgxODu7bROVIolGp3p6y7 tMVGCsg8Q/M1FkcfkcM5jLBomioI0Sw+9WKrdfqkeBdMdg0EB/GuGVCeV6EG/SN64Guv I7QNCtxZcmHUt3LElUowXiFMNt7qOX9aEpi0UhZAK+9eedc7GxrTWYu3meGfftyqLbjH D5Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=0KCnBU9YbtU8AU9N4VQqVJeJx/wZf55o7MkWmg9f/vo=; b=dETwrDcL/sv9hn0kGNYygZsok1amIBoCfgOH0XrQxcLrM8xkaG1MBxqNYEou8rXGCF Yr3FOH1Anaa7P4q0Mx2sr35KDZaajhW+3fa7zC+iruZmT07yocbSnHXDjhEO72hk0VvW KLdPRQBU5Eu/XWZg99jg/Q2L1Da3yOLiYUmgy8COV/wAk7Jpxf2G3GtAH19rAkAA9KbD OwGeyjCmr8FGoigqwSdnrPkxaUdn17SNJbYMOmGC8dpOppWlGqbe6/pJrXEejJB9Ygiy RFodb7ZEpVrz4kjuL1gJ+jQ/UyXpikVa7B5jFonq3G+Ky7IDQVSxgeICGdAUyqT7bv5R QWFw== X-Gm-Message-State: APjAAAWELblziOPWyWe79fjIP9pQe7z36akw3GndhzdgI9MyXtB9gPD1 5rb9YFpDeFKfSzrUILxJ7B/Tp/a8 X-Google-Smtp-Source: APXvYqwUOZjWSHSoA31XrNnT6D03jlw7ki7AG7kdMWTtBU+Ag1jdOiNqoZiVh1LMnudz2fIDlnSBGA== X-Received: by 2002:a5d:4e90:: with SMTP id e16mr9184474wru.224.1573742514542; Thu, 14 Nov 2019 06:41:54 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id a5sm6987371wrv.56.2019.11.14.06.41.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2019 06:41:53 -0800 (PST) In-Reply-To: <83d0du5ye1.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Nov 2019 16:24:38 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242174 Archived-At: >>>>> On Thu, 14 Nov 2019 16:24:38 +0200, Eli Zaretskii said: >> Hmm, with which compiler? Eli> GCC 7.3.0. >> The definition of that function is just before its first use Eli> The paranoid warning options used by the developers' build causes = GCC Eli> to complain about non-static functions that have no prototype in Eli> scope. Oh, I don=CA=BCt run configure with --enable-gcc-warnings (I seem to remember Paul warning against that). >> (and now we have two prototypes for that function, the other is in >> gtkutil.h). Eli> That one should be removed, because gkutil.c (indirectly) includes Eli> font.h, AFAICT. Yes, which causes lots of warnings in a GTK build. Removed. Robert