all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Rudolf Adamkovič" <salutis@me.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: Fix the confusing "result silenced" message
Date: Wed, 30 Nov 2022 01:36:02 +0100	[thread overview]
Message-ID: <m2tu2h9t3h.fsf@me.com> (raw)
In-Reply-To: <m2zgc99tac.fsf@me.com>

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

Rudolf Adamkovič <salutis@me.com> writes:

> Agreed.  Please, see the updated patch.

Oops, I dropped an important word in the commit message.

Please see the third version of patch below.

Rudy


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ob-core-Remove-the-confusing-result-silenced-message.patch --]
[-- Type: text/x-patch, Size: 1081 bytes --]

From c3896ead3e46d705bc4fbee143df87016fe70389 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= <salutis@me.com>
Date: Thu, 24 Nov 2022 22:10:29 +0100
Subject: [PATCH] ob-core: Remove the confusing "result silenced" message

* lisp/ob-core.el (org-babel-execute-src-block): Do not say "result
silenced" after executing the source blocks with `:results none' to
avoid confusion with `:results silent'.
---
 lisp/ob-core.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/ob-core.el b/lisp/ob-core.el
index 5f679a5e9..7abe62022 100644
--- a/lisp/ob-core.el
+++ b/lisp/ob-core.el
@@ -849,8 +849,7 @@ guess will be made."
 		    (setq result (org-babel-ref-resolve post))
 		    (when file
 		      (setq result-params (remove "file" result-params))))))
-	      (if (member "none" result-params)
-		  (message "result silenced")
+	      (unless (member "none" result-params)
 	        (org-babel-insert-result
 	         result result-params info new-hash lang
                  (time-subtract (current-time) exec-start-time))))
-- 
2.38.1


[-- Attachment #3: Type: text/plain, Size: 329 bytes --]

-- 
"Programming reliably -- must be an activity of an undeniably
mathematical nature […] You see, mathematics is about thinking, and
doing mathematics is always trying to think as well as possible."
-- Edsger W. Dijkstra, 1981

Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia

  reply	other threads:[~2022-11-30  0:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-24 21:20 Fix the confusing "result silenced" message Rudolf Adamkovič
2022-11-25  2:10 ` Ihor Radchenko
2022-11-25 23:01   ` Rudolf Adamkovič
2022-11-26  2:16     ` Ihor Radchenko
2022-11-30  0:31       ` Rudolf Adamkovič
2022-11-30  0:36         ` Rudolf Adamkovič [this message]
2022-12-05 11:27           ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2tu2h9t3h.fsf@me.com \
    --to=salutis@me.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.