all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: emacs-devel@gnu.org
Subject: hashtable-print-readable provide point (was: Build failure in current git checkout)
Date: Thu, 06 Aug 2009 07:04:57 -0500	[thread overview]
Message-ID: <m2skg5jggm.fsf@lifelogs.com> (raw)
In-Reply-To: 87skg5d02c.fsf@anzu.internal.golden-gryphon.com

On Wed, 05 Aug 2009 23:43:23 -0500 Manoj Srivastava <srivasta@ieee.org> wrote: 

MS>         I am getting a build failure for the master branch from the git
MS>  repository, summarized below (I can provide more details if needed)

On Thu, 06 Aug 2009 13:39:37 +0300 Teemu Likonen <tlikonen@iki.fi> wrote: 

TL> I git-bisected it to this commit:

TL> commit 3cd069ec588527f4baac7a71d93ccc080668eebf
TL> Author: Teodor Zlatanov <tzz@lifelogs.com>
TL> Date:   Wed Aug 5 09:19:21 2009 +0000

TL>     * lread.c (read1, syms_of_lread): Read hashtables back from the
TL>     readable format.
    
TL>     * print.c (print_preprocess, print_object): Print hashtables fully
TL>     and readably.
TL>     (syms_of_print): Provide 'hashtable-print-readable.

On Thu, 6 Aug 2009 03:13:55 -0700 (PDT) Dan Nicolaescu <dann@ics.uci.edu> wrote: 

DN> This patch breaks the build, temacs crashes on startup.

DN> You cannot call Fprovide in print.c, it's initialized later than that.

When I tested I didn't do a full build.  I'll gladly move the call

  Fprovide (intern ("hashtable-print-readable"), Qnil);
  
to wherever it belongs, but I don't see `provide' called in any other .c
files except for xfns.c (X functions), dbusbins.c, process.c, and
terminal.c.  I don't think this `provide' call belongs in any of them.
I guess process.c is the closest one, but I'd rather not pollute it with
unrelated code.

I can put the `provide' call in the lisp/ tree but again, I don't know
where it should go there.

Ted





  parent reply	other threads:[~2009-08-06 12:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-06  4:43 Build failure in current git checkout Manoj Srivastava
2009-08-06 10:17 ` Daniel Clemente
2009-08-06 10:39 ` Teemu Likonen
2009-08-06 12:04 ` Ted Zlatanov [this message]
2009-08-06 12:56   ` hashtable-print-readable provide point (was: Build failure in current git checkout) Andreas Schwab
2009-08-06 15:12     ` hashtable-print-readable provide point Ted Zlatanov
2009-08-06 18:01     ` Stefan Monnier
2009-08-08 18:41       ` Chong Yidong
2009-08-08 19:55         ` Stefan Monnier
2009-08-28 10:18           ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2skg5jggm.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.