From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Detlev Zundel Newsgroups: gmane.emacs.devel Subject: Re: "RGB" in color.el Date: Thu, 02 Dec 2010 16:01:24 +0100 Organization: Church of Emacs - Missionary division Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1291306823 18579 80.91.229.12 (2 Dec 2010 16:20:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 2 Dec 2010 16:20:23 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 02 17:20:19 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1POBtJ-0001bQ-I6 for ged-emacs-devel@m.gmane.org; Thu, 02 Dec 2010 17:20:18 +0100 Original-Received: from localhost ([127.0.0.1]:35789 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POBtI-0006hC-Q9 for ged-emacs-devel@m.gmane.org; Thu, 02 Dec 2010 11:20:16 -0500 Original-Received: from [140.186.70.92] (port=35500 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POAfN-0000ak-CZ for emacs-devel@gnu.org; Thu, 02 Dec 2010 10:02:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POAfB-0004AV-DM for emacs-devel@gnu.org; Thu, 02 Dec 2010 10:01:49 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:39736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POAfB-00049z-2N for emacs-devel@gnu.org; Thu, 02 Dec 2010 10:01:37 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1POAf9-0001mA-DW for emacs-devel@gnu.org; Thu, 02 Dec 2010 16:01:35 +0100 Original-Received: from p4ff06667.dip.t-dialin.net ([79.240.102.103]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 02 Dec 2010 16:01:35 +0100 Original-Received: from dzu by p4ff06667.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 02 Dec 2010 16:01:35 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 61 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: p4ff06667.dip.t-dialin.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:bsuHDAiRuoaFe+N8oZh364LQSLA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:133317 Archived-At: --=-=-= Content-Type: text/plain Hello Julien, > On Fri, Nov 26 2010, Miles Bader wrote: > >> I think the comments in color.el should be a bit more specific about the >> term "RGB", since that's ambiguous (e.g., in `color-xyz->rgb', the >> comment just says "Converts CIE X Y Z colors to RGB."). >> >> From the code it's pretty clear that what's really meant is "sRGB" so >> maybe that term could just be substituted. > > You are right. > I've fixed that, but feel free to come with something even better. You have missed one rename which bit me just now. The attached patch fixes that. Thanks Detlev -- Of course my password is the same as my pet's name My macaw's name was Q47pY!3 and I change it every 90 days -- Trevor Linton --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-The-recent-rename-of-functions-missed-renaming-one-c.patch >From 43a16ab206e58c596dfe7c5819108e81926b703c Mon Sep 17 00:00:00 2001 From: Detlev Zundel Date: Thu, 2 Dec 2010 15:57:58 +0100 Subject: [PATCH] The recent rename of functions missed renaming one call. Signed-off-by: Detlev Zundel --- lisp/gnus/color.el | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lisp/gnus/color.el b/lisp/gnus/color.el index 4d3718b..d22a71f 100644 --- a/lisp/gnus/color.el +++ b/lisp/gnus/color.el @@ -196,7 +196,7 @@ none is set, `color-d65-xyz' is used." (defun color-lab->srgb (L a b) "Converts CIE L*a*b* to RGB." - (apply 'color-xyz->rgb (color-lab->xyz L a b))) + (apply 'color-xyz->srgb (color-lab->xyz L a b))) (defun color-cie-de2000 (color1 color2 &optional kL kC kH) "Computes the CIEDE2000 color distance between COLOR1 and COLOR2. -- 1.7.2.3 --=-=-=--