From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "John Wiegley" Newsgroups: gmane.emacs.devel Subject: Re: commit 108757 breaks clang build on so x Date: Fri, 29 Jun 2012 17:20:13 -0500 Organization: New Artisans LLC Message-ID: References: <7ifw9epolx.fsf@mack.tetzco.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1341008428 3040 80.91.229.3 (29 Jun 2012 22:20:28 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 29 Jun 2012 22:20:28 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 30 00:20:27 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SkjY9-00051m-9f for ged-emacs-devel@m.gmane.org; Sat, 30 Jun 2012 00:20:25 +0200 Original-Received: from localhost ([::1]:33045 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SkjY9-000758-82 for ged-emacs-devel@m.gmane.org; Fri, 29 Jun 2012 18:20:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SkjY6-00074i-4h for emacs-devel@gnu.org; Fri, 29 Jun 2012 18:20:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SkjY2-0002TI-JQ for emacs-devel@gnu.org; Fri, 29 Jun 2012 18:20:21 -0400 Original-Received: from mail-gh0-f169.google.com ([209.85.160.169]:52903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SkjY2-0002RY-Cj for emacs-devel@gnu.org; Fri, 29 Jun 2012 18:20:18 -0400 Original-Received: by ghrr18 with SMTP id r18so3820976ghr.0 for ; Fri, 29 Jun 2012 15:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:organization:references:mail-followup-to :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=8/bkGsZ8fwtsjP/KABLn5QxB6FPHN7iVvdYD1JNbamc=; b=0aNGvf7KFj5VaA2PWBk4LpW5JPGxB9Nt/I3mhIqeRWfFwsXKqsci6lMyVX/oPKh/v7 lZkdPDdDrYiovROBM1MsFlbdOGYG3m6TBJUHyIeC/WhziJA4Y1Bf78TSuFPi9t8uQr/F gBbuB4a6UmGoPWznTpAFj1PHe5vvg654g4zvmCZ8xnqGO1RtUfKyNqCaUx2AEJeYqfNI ggaXxrYYI7/3NzWSz2gr/n+myJVNrQIxNSm5Bpb0rD47LFjrr/tKFg9BjHIkCQqGW6qw 5qGHqkR9i9BvzcgFYSL13wjynaKD2q6+8NUz8Nuk0xX4SQHFwT54AkZDds5qY7vTV0M1 Mh6g== Original-Received: by 10.50.188.131 with SMTP id ga3mr404407igc.54.1341008416633; Fri, 29 Jun 2012 15:20:16 -0700 (PDT) Original-Received: from vulcan.local (c-98-215-105-167.hsd1.il.comcast.net. [98.215.105.167]) by mx.google.com with ESMTPS id y5sm5980400igb.11.2012.06.29.15.20.14 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 29 Jun 2012 15:20:15 -0700 (PDT) Original-Received: by vulcan.local (Postfix, from userid 501) id DE3D4F240038; Fri, 29 Jun 2012 17:20:13 -0500 (CDT) Mail-Followup-To: emacs-devel@gnu.org In-Reply-To: <7ifw9epolx.fsf@mack.tetzco.de> (Kai Tetzlaff's message of "Fri, 29 Jun 2012 09:24:26 +0200") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1 (darwin) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.160.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151305 Archived-At: >>>>> Kai Tetzlaff writes: > It seems that > __attribute__((no_address_safety_analysis)) > is not supported by all clang versions. The attached patch contains an > improved version of the check which hopefully fixes the problem (it does so > here). Thanks for catching that, Kai. I forgot that the address sanitizer was only introduced in 3.1. FYI- The sanitizer only works up to the temacs build. The dumped Emacs that results will not work because static construction/destruction fails in the ASan libraries. Until I can build Clang with shared ASan libraries (I've entered a bug against this in their bugtracker), running a fully sanitized Emacs is still a pipe dream. It has already found one legitimate stack overwrite in charset.c. I'm still testing the fix. John