all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "John Wiegley" <johnw@newartisans.com>
To: emacs-devel@gnu.org
Subject: Re: commit 108757 breaks clang build on so x
Date: Fri, 29 Jun 2012 17:20:13 -0500	[thread overview]
Message-ID: <m2sjdd92w2.fsf@newartisans.com> (raw)
In-Reply-To: <7ifw9epolx.fsf@mack.tetzco.de> (Kai Tetzlaff's message of "Fri,  29 Jun 2012 09:24:26 +0200")

>>>>> Kai Tetzlaff <kai.tetzlaff@web.de> writes:

> It seems that

>   __attribute__((no_address_safety_analysis))

> is not supported by all clang versions. The attached patch contains an
> improved version of the check which hopefully fixes the problem (it does so
> here).

Thanks for catching that, Kai.  I forgot that the address sanitizer was only
introduced in 3.1.

FYI- The sanitizer only works up to the temacs build.  The dumped Emacs that
results will not work because static construction/destruction fails in the
ASan libraries.  Until I can build Clang with shared ASan libraries (I've
entered a bug against this in their bugtracker), running a fully sanitized
Emacs is still a pipe dream.

It has already found one legitimate stack overwrite in charset.c.  I'm still
testing the fix.

John



      reply	other threads:[~2012-06-29 22:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29  7:24 commit 108757 breaks clang build on os x Kai Tetzlaff
2012-06-29 22:20 ` John Wiegley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2sjdd92w2.fsf@newartisans.com \
    --to=johnw@newartisans.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.