all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Darren Hoo <darren.hoo@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-24 r117050: Consult libpng-config more consistently.
Date: Tue, 06 May 2014 13:04:31 +0800	[thread overview]
Message-ID: <m2sionebvk.fsf@gmail.com> (raw)
In-Reply-To: <E1WgJDk-00066x-1c@vcs.savannah.gnu.org> (Paul Eggert's message of "Fri, 02 May 2014 19:34:08 +0000")


I would like to remind  osx users that this change might cause build to
fail if HomeBrew (with libpng) or XQuartz is installed, unset PATH before
running ./configure so that libpng-config won't interfere.

A question about code around line 5919 of image.c,
Shouldn't this if conditional wrap the last line in?


	  /* We use the current frame background, ignoring any default
	     background color set by the image.  */
#if defined (HAVE_X_WINDOWS) || defined (HAVE_NTGUI)
	  XColor color;
	  png_color_16 frame_background;

	  color.pixel = FRAME_BACKGROUND_PIXEL (f);
	  x_query_color (f, &color);

	  memset (&frame_background, 0, sizeof frame_background);
	  frame_background.red = color.red >> shift;
	  frame_background.green = color.green >> shift;
	  frame_background.blue = color.blue >> shift;
#endif /* HAVE_X_WINDOWS */

	  fn_png_set_background (png_ptr, &frame_background,
				 PNG_BACKGROUND_GAMMA_SCREEN, 0, 1.0);






      parent reply	other threads:[~2014-05-06  5:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1WgJDk-00066x-1c@vcs.savannah.gnu.org>
2014-05-04  1:15 ` Emacs-diffsemacs-24 r117050: Consult libpng-config more consistently Glenn Morris
2014-05-04  6:37   ` Paul Eggert
2014-05-04 17:57     ` Glenn Morris
2014-05-04 18:53       ` Paul Eggert
2014-05-06  5:04 ` Darren Hoo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2sionebvk.fsf@gmail.com \
    --to=darren.hoo@gmail.com \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.