combine-and-quote-strings

[Philipp Stephani <p.stephani2@gmail.com>]

Hi,

the Lisp manual explains (in the section "Shell Arguments"):

    The following two functions are useful for combining a list of
    individual command-line argument strings into a single string,

This is about combine-and-quote-strings (and
split-strings-and-unquote).  However, combine-and-quote-strings can't
really be used for that purpose because it doesn't quote many shell
metacharacters.  The correct way to shell-quote a list of arguments is

    (mapconcat #'shell-quote-argument ARGS " ")

Should combine-and-quote-strings be reimplemented in terms of
shell-quote-argument?  The current definition doesn't seem to be optimal
for shell quoting because many inputs aren't properly quoted.

Or is combine-and-quote-strings not intended for shell quoting at all
and the documentation should be adapted?

Thanks,
Philipp