From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master ed2b0bd: New faces in xref (bug#23179) Date: Tue, 16 Apr 2019 16:02:36 +0200 Message-ID: References: <20190413215421.15465.98417@vcs0.savannah.gnu.org> <20190413215422.72DC12044D@vcs0.savannah.gnu.org> <87o958wdwt.fsf@mail.linkov.net> <83lg0bibh6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="5433"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 16 16:03:54 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGOgj-0001JH-Oi for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 16:03:53 +0200 Original-Received: from localhost ([127.0.0.1]:37470 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGOgi-0003BB-Lt for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 10:03:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGOff-0002eR-0v for emacs-devel@gnu.org; Tue, 16 Apr 2019 10:02:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGOfe-0002Ie-09 for emacs-devel@gnu.org; Tue, 16 Apr 2019 10:02:46 -0400 Original-Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:38069) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGOfd-0002I7-PA; Tue, 16 Apr 2019 10:02:45 -0400 Original-Received: by mail-wr1-x42e.google.com with SMTP id k11so27276131wro.5; Tue, 16 Apr 2019 07:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:message-id:mime-version :content-transfer-encoding; bh=JJERv6eoQVuNWyMY6NuV9YBsW9cuhShTl13EcmOmLoo=; b=O4I+HdEuPTdyb4NVBopGdfeEpeTbFdT+6A2HTJ+JJD6D+HbC+teWg3oCNLGX4VedH7 zJzuGBfewQvQczgdFWbRj21K2+MFuipxSrYKnflavIoaZaB7g9NhRnsJpdL1+ann/vh7 mYRRmr/4ry/2/PM85vn6YzWn9mLgfvRaBSCH9EIfb3g9F8cUKOxFx2rQ1rg50Q9s334N WHrxe3q7HMsP9bUjUUQysHjmYtoWOByt8h9D4cTjutPJjIPY4ILp1bVIIIb5BPn4JASc aVGPJLT/CcVZ8Z1DHKY9+MjUw8munBZ2qZUHLl2Q5sJTTb27OQBkcEtd27RGJ31gthUG qSqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:message-id:mime-version :content-transfer-encoding; bh=JJERv6eoQVuNWyMY6NuV9YBsW9cuhShTl13EcmOmLoo=; b=LE8yXU7jwH0GXftoELGomwKQcGfQwWiYlpqk91B/gHWWarQMtElVSROxYe8UvErjvW KfCCh7Apl0m1A8ffIrDGtzAgkZ9BB2otSMxE78vhi3dnL7Q/TZYHcph3VPTn0orRy7Vp Xvy7FrDjq6occ3i3shXumiOEx9HYbiHT2/g9Qa9p85bh6cR46cW5PX1Eu2hGLqxU28ml TaGM3zN0p0vZSk88g0E6FnD+kgZAInesp12yujt9Og7ca/aVNUnVFA0e5ZFN2iBUiYIf AmjZcIsmj/zhiojBuERb1YWw6YtpUqBORQFl9eWLls7tGGtZdOels6kuXvr2uX13pjjO rJiQ== X-Gm-Message-State: APjAAAWd9Xtv7Xbn8z7wA1z0iXHnMV3BEre94egSsjFuxl8k91i14gGU NNc2nxwFaE105Ze86d1FmsDeFIQJ X-Google-Smtp-Source: APXvYqxC9CHSQL2j4JpUBSv1AThVSrgUCOH3EeZMRy9m7K2KVmw1z94C/LPtKvk7w93cUQ3JdTGyWA== X-Received: by 2002:adf:dd8c:: with SMTP id x12mr21667844wrl.262.1555423358373; Tue, 16 Apr 2019 07:02:38 -0700 (PDT) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id e1sm87596595wrw.66.2019.04.16.07.02.36 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 16 Apr 2019 07:02:37 -0700 (PDT) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235518 Archived-At: >>>>> On Mon, 15 Apr 2019 17:34:13 +0300, Eli Zaretskii said: >> From: Robert Pluim Date: Mon, 15 Apr 2019 >> 10:27:45 +0200 Cc: emacs-devel@gnu.org >>=20 Juri> I see no other related faces (compilation/grep) mentioned Juri> neither in NEWS nor in the manual. >>=20 >> True. That=CA=BCs arguably a deficiency in the manual. Eli> I tend to agree. Feel free to document at least the more Eli> important ones ('error', 'warning'). grep doesn=CA=BCt have any faces that can be customized (at least not for the output of grep. How about the following for compilation-mode: diff --git a/doc/emacs/building.texi b/doc/emacs/building.texi index 78d07b8d39..fa4c7f0e20 100644 --- a/doc/emacs/building.texi +++ b/doc/emacs/building.texi @@ -151,6 +151,23 @@ Compilation Mode the error message in a separate window. The locus is the specific position in a file where that error occurred. =20 +@cindex compilation mode faces +@cindex compilation mode appearance +@vindex compilation-error-face +@vindex compilation-error +@vindex compilation-warning-face +@vindex compilation-warning + The appearance of the @file{*compilation*} buffer can be controlled +by customizing the faces which are used to highlight parts of the +@file{*compilation*} buffer, e.g. @code{compilation-error} or +@code{compilation-warning}, for error and warning messages +respectively. Note that since those faces inherit from the +@code{error} and @code{warning} faces, it is also possible to +customize the parent face directly instead. + + Use @w{@kbd{M-x customize-group RET compilation}} to see the entire +list of customization variables and faces. + @findex compile-goto-error @vindex compilation-auto-jump-to-first-error If you change the variable