all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* The annotated example of a complete working Flymake backend leaves process buffers around
@ 2021-10-23  7:17 Rudolf Adamkovič
  2021-10-23  7:43 ` Manuel Uberti
  2021-10-23  7:47 ` Stefan Kangas
  0 siblings, 2 replies; 5+ messages in thread
From: Rudolf Adamkovič @ 2021-10-23  7:17 UTC (permalink / raw)
  To: emacs-devel

I noticed that the "annotated example of a complete working Flymake backend" at

<https://www.gnu.org/software/emacs/manual/html_mono/flymake.html#Backend-functions>

leaves zombie buffers around. I traced the problem down to

┌────
│ (when (eq 'exit (process-status proc)) …
└────

The backend kills the process buffer on `'exit' but not on `'signal', which happens when Flymake kills an obsolete in-progress check. I fixed the problem locally with

┌────
│ (let ((status (process-status proc)))
│   (when (or (eq status 'exit) (eq status 'signal))
│     …
└────

I think we should fix the Flymake manual as well.

Rudy
-- 
"'Contrariwise,' continued Tweedledee, 'if it was so, it might be; and if it were so, it would be; but as it isn't, it ain't. That's logic.'" -- Lewis Carroll, Through the Looking Glass

Rudolf Adamkovič <salutis@me.com>
Studenohorská 25
84103 Bratislava
Slovakia

[he/him]



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: The annotated example of a complete working Flymake backend leaves process buffers around
  2021-10-23  7:17 The annotated example of a complete working Flymake backend leaves process buffers around Rudolf Adamkovič
@ 2021-10-23  7:43 ` Manuel Uberti
  2021-10-23  7:47 ` Stefan Kangas
  1 sibling, 0 replies; 5+ messages in thread
From: Manuel Uberti @ 2021-10-23  7:43 UTC (permalink / raw)
  To: emacs-devel

On 23/10/21 09:17, Rudolf Adamkovič wrote:
> The backend kills the process buffer on `'exit' but not on `'signal', which happens when Flymake kills an obsolete in-progress check. I fixed the problem locally with
> 
> ┌────
> │ (let ((status (process-status proc)))
> │   (when (or (eq status 'exit) (eq status 'signal))
> │     …
> └────

Hi Rudolf,

thank you for this tip, I've applied it to a couple of Flymake backends I worked 
on (namely flymake-proselint and flymake-kondor).


Regards

-- 
Manuel Uberti
www.manueluberti.eu



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: The annotated example of a complete working Flymake backend leaves process buffers around
  2021-10-23  7:17 The annotated example of a complete working Flymake backend leaves process buffers around Rudolf Adamkovič
  2021-10-23  7:43 ` Manuel Uberti
@ 2021-10-23  7:47 ` Stefan Kangas
  2021-10-24 20:05   ` Rudolf Adamkovič
  1 sibling, 1 reply; 5+ messages in thread
From: Stefan Kangas @ 2021-10-23  7:47 UTC (permalink / raw)
  To: Rudolf Adamkovič, emacs-devel

Rudolf Adamkovič <salutis@me.com> writes:

> I noticed that the "annotated example of a complete working Flymake backend" at
>
> <https://www.gnu.org/software/emacs/manual/html_mono/flymake.html#Backend-functions>
>
> leaves zombie buffers around.

Could you send this same message to bug-gnu-emacs@gnu.org so we can
track it as a bug?

Bug reports unfortunately tend to get forgotten on emacs-devel, due to
the high number of messages and lack of tracking.

Thanks in advance.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: The annotated example of a complete working Flymake backend leaves process buffers around
  2021-10-23  7:47 ` Stefan Kangas
@ 2021-10-24 20:05   ` Rudolf Adamkovič
  2021-10-25  8:23     ` João Távora
  0 siblings, 1 reply; 5+ messages in thread
From: Rudolf Adamkovič @ 2021-10-24 20:05 UTC (permalink / raw)
  To: emacs-devel; +Cc: Stefan Kangas

Stefan Kangas <stefankangas@gmail.com> writes:

> Could you send this same message to bug-gnu-emacs@gnu.org so we can
> track it as a bug?

Oops! Sorry for the noise. Opened bug#51380.

Thank you, Stefan, for you guidance.

Rudy

-- 
"Logic is a science of the necessary laws of thought, without which no employment of the understanding and the reason takes place." -- Immanuel Kant, 1785

Rudolf Adamkovič <salutis@me.com>
Studenohorská 25
84103 Bratislava
Slovakia

[he/him]



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: The annotated example of a complete working Flymake backend leaves process buffers around
  2021-10-24 20:05   ` Rudolf Adamkovič
@ 2021-10-25  8:23     ` João Távora
  0 siblings, 0 replies; 5+ messages in thread
From: João Távora @ 2021-10-25  8:23 UTC (permalink / raw)
  To: Rudolf Adamkovič; +Cc: Stefan Kangas, emacs-devel

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

Thank for finding and pinpointing this!
Please CC me in that bug report.

João

(And yes, the manual recipe probably needs fixing)

On Sun, Oct 24, 2021, 21:06 Rudolf Adamkovič <salutis@me.com> wrote:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
> > Could you send this same message to bug-gnu-emacs@gnu.org so we can
> > track it as a bug?
>
> Oops! Sorry for the noise. Opened bug#51380.
>
> Thank you, Stefan, for you guidance.
>
> Rudy
>
> --
> "Logic is a science of the necessary laws of thought, without which no
> employment of the understanding and the reason takes place." -- Immanuel
> Kant, 1785
>
> Rudolf Adamkovič <salutis@me.com>
> Studenohorská 25
> 84103 Bratislava
> Slovakia
>
> [he/him]
>
>

[-- Attachment #2: Type: text/html, Size: 1408 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-10-25  8:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-23  7:17 The annotated example of a complete working Flymake backend leaves process buffers around Rudolf Adamkovič
2021-10-23  7:43 ` Manuel Uberti
2021-10-23  7:47 ` Stefan Kangas
2021-10-24 20:05   ` Rudolf Adamkovič
2021-10-25  8:23     ` João Távora

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.