From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "John Wiegley" Newsgroups: gmane.emacs.devel Subject: Re: Removal of syntax-ppss-last Date: Mon, 02 Oct 2017 16:02:36 -0400 Message-ID: References: <20171002170444.GA18364@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1506974582 31479 195.159.176.226 (2 Oct 2017 20:03:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 2 Oct 2017 20:03:02 +0000 (UTC) User-Agent: Gnus/5.130016 (Ma Gnus v0.16) Emacs/26.0 (darwin) Cc: Dmitry Gutov , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 02 22:02:53 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dz6vQ-0006uh-LF for ged-emacs-devel@m.gmane.org; Mon, 02 Oct 2017 22:02:48 +0200 Original-Received: from localhost ([::1]:53946 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dz6vX-0005SR-M4 for ged-emacs-devel@m.gmane.org; Mon, 02 Oct 2017 16:02:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dz6vQ-0005SG-9s for emacs-devel@gnu.org; Mon, 02 Oct 2017 16:02:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dz6vN-0008Np-1k for emacs-devel@gnu.org; Mon, 02 Oct 2017 16:02:48 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dz6vM-0008Nl-UO; Mon, 02 Oct 2017 16:02:44 -0400 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:60073) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1dz6vM-00040w-27; Mon, 02 Oct 2017 16:02:44 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 2DF4220F29; Mon, 2 Oct 2017 16:02:41 -0400 (EDT) Original-Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Mon, 02 Oct 2017 16:02:41 -0400 X-ME-Sender: X-Sasl-enc: MhFGTcRD66ZhkzaEpSmc2TtPbWEx5VU/0WB+LYmDCloB 1506974560 Original-Received: from Hermes.local (85.sub-174-192-6.myvzw.com [174.192.6.85]) by mail.messagingengine.com (Postfix) with ESMTPA id F30EC249CD; Mon, 2 Oct 2017 16:02:40 -0400 (EDT) Original-Received: by Hermes.local (Postfix, from userid 501) id 043B732604BB; Mon, 2 Oct 2017 16:02:39 -0400 (EDT) In-Reply-To: <20171002170444.GA18364@ACM> (Alan Mackenzie's message of "Mon, 2 Oct 2017 17:04:44 +0000") Mail-Followup-To: Alan Mackenzie , emacs-devel@gnu.org, Dmitry Gutov X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219021 Archived-At: >>>>> "AM" == Alan Mackenzie writes: AM> syntax-ppss-last was intended as an internal variable in syntax.el. Why AM> was haskell-mode using it? (If indeed it was). Apologies for the vagueness, I'm traveling at the moment and didn't dig into this enough fully. Here's the function that raised the error: (defun haskell-indentation-find-indentations () (let ((ppss (syntax-ppss))) (cond ((nth 3 ppss) (haskell-indentation-first-indentation)) ((nth 4 ppss) (if (save-excursion (and (skip-syntax-forward "-") (eolp) (not (> (forward-line 1) 0)) (not (nth 4 (syntax-ppss))))) (haskell-indentation-parse-to-indentations) (haskell-indentation-first-indentation))) (t (haskell-indentation-parse-to-indentations))))) So it would seem that the byte-compiled file is referencing the variable. When I re-evaluate the file this definition is contained in, the error goes away. Unfortunate, but easily solved. And I don't believe we guarantee .elc compatibility between major releases. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2