all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "John Wiegley" <johnw@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: Dmitry Gutov <dgutov@yandex.ru>, emacs-devel@gnu.org
Subject: Re: Removal of syntax-ppss-last
Date: Mon, 02 Oct 2017 16:02:36 -0400	[thread overview]
Message-ID: <m2r2ul9v37.fsf@newartisans.com> (raw)
In-Reply-To: <20171002170444.GA18364@ACM> (Alan Mackenzie's message of "Mon, 2 Oct 2017 17:04:44 +0000")

>>>>> "AM" == Alan Mackenzie <acm@muc.de> writes:

AM> syntax-ppss-last was intended as an internal variable in syntax.el. Why
AM> was haskell-mode using it? (If indeed it was).

Apologies for the vagueness, I'm traveling at the moment and didn't dig into
this enough fully.

Here's the function that raised the error:

(defun haskell-indentation-find-indentations ()
  (let ((ppss (syntax-ppss)))
    (cond
     ((nth 3 ppss)
      (haskell-indentation-first-indentation))
     ((nth 4 ppss)
      (if (save-excursion
            (and (skip-syntax-forward "-")
                 (eolp)
                 (not (> (forward-line 1) 0))
                 (not (nth 4 (syntax-ppss)))))
          (haskell-indentation-parse-to-indentations)
        (haskell-indentation-first-indentation)))
     (t
      (haskell-indentation-parse-to-indentations)))))

So it would seem that the byte-compiled file is referencing the variable. When
I re-evaluate the file this definition is contained in, the error goes away.

Unfortunate, but easily solved. And I don't believe we guarantee .elc
compatibility between major releases.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2



  reply	other threads:[~2017-10-02 20:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-02 15:02 Removal of syntax-ppss-last John Wiegley
2017-10-02 17:04 ` Alan Mackenzie
2017-10-02 20:02   ` John Wiegley [this message]
2017-10-03  0:48     ` Stefan Monnier
2017-10-03 21:19       ` John Wiegley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2r2ul9v37.fsf@newartisans.com \
    --to=johnw@gnu.org \
    --cc=acm@muc.de \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.