all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: string_char_to_byte and string_byte_to_char micro-optimisation
Date: Mon, 17 Jun 2019 11:37:15 +0200	[thread overview]
Message-ID: <m2r27sh7sk.fsf@gmail.com> (raw)
In-Reply-To: b7788422-ec36-20ea-1a8e-28f2cf0f6109@cs.ucla.edu

>>>>> On Fri, 14 Jun 2019 09:53:50 -0700, Paul Eggert <eggert@cs.ucla.edu> said:

    Paul> On 6/14/19 5:37 AM, Robert Pluim wrote:
    >> What I donʼt have is any intuition on whether such a change actually
    >> makes any difference in real-world Emacs usage. Can anyone suggest any
    >> benchmarks?

    Paul> My usual benchmark for this sort of thing is 'make compile-always' in
    Paul> the lisp directory.

It doesnʼt make a significant difference, so I donʼt think thereʼs any
point in complicating the code:

With patch, run 1:

real	4m21.097s
user	3m39.020s
sys	0m33.267s

With patch, run 2:

real	4m13.649s
user	3m34.102s
sys	0m31.834s

Without patch, run 1:

real	4m15.264s
user	3m34.305s
sys	0m32.719s

Without patch, run 2:

real	4m18.266s
user	3m36.531s
sys	0m33.315s



      parent reply	other threads:[~2019-06-17  9:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 12:37 string_char_to_byte and string_byte_to_char micro-optimisation Robert Pluim
2019-06-14 16:53 ` Paul Eggert
2019-06-14 19:00   ` Eli Zaretskii
2019-06-14 20:11     ` Stefan Monnier
2019-06-15  6:22       ` Eli Zaretskii
2019-06-15  7:48         ` Stefan Monnier
2019-06-15 11:11           ` Noam Postavsky
2019-06-16 11:17             ` Stefan Monnier
2019-06-17  9:37   ` Robert Pluim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2r27sh7sk.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.