From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Keith David Bershatsky Newsgroups: gmane.emacs.devel Subject: Re: -getRed:green:blue:alpha: not defined for the NSColor Date: Sat, 13 Jul 2019 11:10:29 -0700 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="160983"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 13 20:10:38 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmMTl-000fjI-A1 for ged-emacs-devel@m.gmane.org; Sat, 13 Jul 2019 20:10:37 +0200 Original-Received: from localhost ([::1]:57610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmMTj-0007Ln-UU for ged-emacs-devel@m.gmane.org; Sat, 13 Jul 2019 14:10:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50364) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmMTh-0007Lh-8q for emacs-devel@gnu.org; Sat, 13 Jul 2019 14:10:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmMTg-0002lV-E0 for emacs-devel@gnu.org; Sat, 13 Jul 2019 14:10:33 -0400 Original-Received: from gateway24.websitewelcome.com ([192.185.51.251]:40619) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hmMTg-0002ku-3N for emacs-devel@gnu.org; Sat, 13 Jul 2019 14:10:32 -0400 Original-Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 3523B21A6 for ; Sat, 13 Jul 2019 13:10:31 -0500 (CDT) Original-Received: from gator3053.hostgator.com ([50.87.144.69]) by cmsmtp with SMTP id mMTehVA9WdnCemMTfh1UNG; Sat, 13 Jul 2019 13:10:31 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lawlist.com ; s=default; h=Content-Type:MIME-Version:Subject:Cc:To:From:Message-ID:Date: Sender:Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=u8n5DOqXmmq0xyHmIJYr2hBp+EqbBWCaqu3xQVctw9M=; b=SRtQGLHP2soESFvVtfP7Y5lx4C lecEhjQsjxNLX1rvahRKuFn7j3S+d9Pu9p96VQcnQ3/Aw/iAIz5a1o4+no7iwx0WNmLWZ07n/cFhw buqrNzOHGFTPvwf2rXEehf7ifd/vyNyvUEXOsr8FjCcfuqdkX6fRlDdGeMlpcLcp5D32lNZp9AgvA lk7et8FQD8P9oU3BvsTGxdSN7ptNQi9LZLR1hSsw1gKDeJJtI17Ikv6uoBuOdM+bZG0IP0sZN9Evj z8tO+sHNd29zRlAhHhdcac2arr4mO+62RsThD17SyaazewMoDMjZy/HYtSi9lL3vZB9FbGbk5HzT4 85msTBRQ==; Original-Received: from cpe-45-48-239-195.socal.res.rr.com ([45.48.239.195]:51027 helo=server.local) by gator3053.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hmMTe-0036rO-EK; Sat, 13 Jul 2019 13:10:30 -0500 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator3053.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lawlist.com X-BWhitelist: no X-Source-IP: 45.48.239.195 X-Source-L: No X-Exim-ID: 1hmMTe-0036rO-EK X-Source-Sender: cpe-45-48-239-195.socal.res.rr.com (server.local) [45.48.239.195]:51027 X-Source-Auth: lawlist X-Email-Count: 1 X-Source-Cap: bGF3bGlzdDtsYXdsaXN0O2dhdG9yMzA1My5ob3N0Z2F0b3IuY29t X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 192.185.51.251 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238569 Archived-At: The following change made with 9624f609493da7c08016ba00d6895bad0fe26a0e is what prevents Emacs on OSX 10.6.8 from working. Would it be possible for the Emacs team to put in a condition that permits Emacs on OSX 10.6 to use the two lines of code that were removed? [I do not know what is the earliest version of OSX that can make use of two new lines of code without breaking.] diff --git a/src/nsimage.m b/src/nsimage.m index 33236c4..0249d22 100644 --- a/src/nsimage.m +++ b/src/nsimage.m @@ -313,8 +313,8 @@ - (instancetype)setXBMColor: (NSColor *)color if (bmRep == nil || color == nil) return self; - if ([color colorSpaceName] != NSCalibratedRGBColorSpace) - rgbColor = [color colorUsingColorSpaceName: NSCalibratedRGBColorSpace]; + if ([color colorSpace] != [NSColorSpace deviceRGBColorSpace]) + rgbColor = [color colorUsingColorSpace:[NSColorSpace deviceRGBColorSpace]]; else rgbColor = color;