Re: -getRed:green:blue:alpha: not defined for the NSColor

[Keith David Bershatsky <esq@lawlist.com>]

Thank you, Alan, for working on this -- greatly appreciated!

Yes, your proposed modification works well for Emacs on OSX 10.6.8.  Emacs starts up just fine and there are no error messages in the gdb terminal.  I did some light testing with cursor movement and splitting windows from the Emacs welcome screen ...

Keith

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

> Date: [07-14-2019 03:24:11] <14 Jul 2019 11:24:11 +0100>
> From: Alan Third <alan@idiocy.org>
> 
> * * *
> 
> modified   src/nsimage.m
> @@ -310,6 +310,6 @@ - (instancetype)setXBMColor: (NSColor *)color
>      return self;
> 
> -  if ([color colorSpace] != [NSColorSpace deviceRGBColorSpace])
> -    rgbColor = [color colorUsingColorSpace:[NSColorSpace deviceRGBColorSpace]];
> +  if ([color colorSpace] != [NSColorSpace genericRGBColorSpace])
> +    rgbColor = [color colorUsingColorSpace:[NSColorSpace genericRGBColorSpace]];
>    else
>      rgbColor = color;