From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#40097: 28.0.50; Preferred font ignored for specific charset Date: Wed, 18 Mar 2020 21:47:19 +0100 Message-ID: References: <87r1xriovt.fsf@osv.gnss.ru> <831rprgg2g.fsf@gnu.org> <87tv2narke.fsf@osv.gnss.ru> <83wo7jey86.fsf@gnu.org> <83lfnxg2ik.fsf@gnu.org> <83d099frx8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="100247"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sorganov@gmail.com, 40097@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 18 21:48:25 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jEfc1-000Pry-NF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Mar 2020 21:48:25 +0100 Original-Received: from localhost ([::1]:58492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEfc0-00036O-NH for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Mar 2020 16:48:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46527) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEfbf-00034r-3Q for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 16:48:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEfbd-0005Lq-U6 for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 16:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35522) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jEfbd-0005Kc-PA for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 16:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jEfbd-0000MZ-NN for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 16:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Mar 2020 20:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40097 X-GNU-PR-Package: emacs Original-Received: via spool by 40097-submit@debbugs.gnu.org id=B40097.1584564452841 (code B ref 40097); Wed, 18 Mar 2020 20:48:01 +0000 Original-Received: (at 40097) by debbugs.gnu.org; 18 Mar 2020 20:47:32 +0000 Original-Received: from localhost ([127.0.0.1]:41495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEfb9-0000D6-DN for submit@debbugs.gnu.org; Wed, 18 Mar 2020 16:47:31 -0400 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:56245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEfb7-00008F-Ol for 40097@debbugs.gnu.org; Wed, 18 Mar 2020 16:47:30 -0400 Original-Received: by mail-wm1-f54.google.com with SMTP id 6so5042861wmi.5 for <40097@debbugs.gnu.org>; Wed, 18 Mar 2020 13:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=4RuppZtppA5tDikJPjQSLwkSOjtBIV4OkhFlBSSvzfE=; b=KpfpHbNPkcxxAmN8/bj27x8FAD3I70ZpbvDb08XWcqYK0raqs/exsZP5NZAbaOqyKQ 4TDQmJMlc27rXB33V1DQ72O/NS4OAjx2HPoYW0SmYBLRRRYQIRe2yGhIc1Lr1PNTC/L7 Dlrz1Snx0m8/4EkwNg/dcwZmEOA4bvhgW7Twy+r+1virn8vvdtjguxWUUCzJVjj2V84a FLcKRm71c405KHGGxaFLVQ1VIvtPOq3pViSqbAOQx8TlDNcgf9Mt5Ucd7eZpsn/N96/k CAMg/ULEzZtYHhlNQ7BflUgz1QYVkqIkOuvV9sUk55GW2dGkRd26YHFx6Qt+xABUwJhA 1+Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=4RuppZtppA5tDikJPjQSLwkSOjtBIV4OkhFlBSSvzfE=; b=G8SuzCbb0QcoW2Yj5tdkmxp0R39n6lSJZXTCck29adb+8LIWpMJPn4ZsdgM7BOkag/ J+rKuLL0msTYKlJkHXzlh7IXqtagRsPZrgHTBcDMxIrImx1FxcmvUkMsvmbvC2AaOUm4 ShEtXAEaYqUDMcxPtvVqtoZjKuYVt6FzIePXI6mLzrE5tHgJi3T3KQSRwcShCe35xVSn 4t/W/QR/yEIWZRLbBO1Z3dpSM4Bf8RMb7LRaKb70OQaCUC5mGCEwd1g6RM6pJ7BgWOFM WMmt4TrrmB97X4HLYGJAGf6mpJ2eJUVmvEbCCGDg62HY7DpbKpeAjpaIif0K2MHhNg5w wgvw== X-Gm-Message-State: ANhLgQ0XeZQw9N2iz02GBmwlyEOdrrvHlUQRHWnBJ/40naVPF7t1HgGp nWNETvpFWQR0VR/zW4HfuNBMVK3q X-Google-Smtp-Source: ADFU+vubZ3ifR5K5XRbpXOJ8qr/pWhOKLOwVaPdySkSuAberv2sZfBWD7CR6DXUKGxorefOeOpnMdg== X-Received: by 2002:a05:600c:204:: with SMTP id 4mr6719151wmi.112.1584564443319; Wed, 18 Mar 2020 13:47:23 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:a5e4:a54d:af0e:151]) by smtp.gmail.com with ESMTPSA id x206sm5122318wmg.17.2020.03.18.13.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2020 13:47:22 -0700 (PDT) In-Reply-To: <83d099frx8.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 18 Mar 2020 20:18:11 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177521 Archived-At: --=-=-= Content-Type: text/plain >>>>> On Wed, 18 Mar 2020 20:18:11 +0200, Eli Zaretskii said: >> From: Robert Pluim >> Cc: sorganov@gmail.com, handa@gnu.org, 40097@debbugs.gnu.org >> Date: Wed, 18 Mar 2020 17:28:47 +0100 >> >> ftfont.c: >> >> { "windows-1251", { 0x0401, 0x0490 }, "ru"}, >> >> Thread 1 "emacs" hit Breakpoint 3, ftfont_get_charset (registry=XIL(0x394540)) at ftfont.c:486 >> 486 for (i = j = 0; i < SBYTES (SYMBOL_NAME (registry)); i++, j++) >> (gdb) pp registry >> microsoft-cp1251 >> (gdb) >> >> So correcting the name of the registry in ftfont.c fixes this. Eli> You mean, fixing that makes DejaVu Sans Mono be used in this case? Yes. Eli> That's great, let's fix this in emacs-27 then. If you want me to be conservative, I could *add* a microsoft-cp1251 entry instead of replacing windows-1251, but as far as I know windows-1251 is not a valid registry name. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Use-correct-registry-name-for-windows-1251-charset.patch >From c0001bb3cd097809f152fe9ca985aa319a957678 Mon Sep 17 00:00:00 2001 From: Robert Pluim Date: Wed, 18 Mar 2020 21:37:55 +0100 Subject: [PATCH] Use correct registry name for windows-1251 charset To: emacs-devel@gnu.org * src/ftfont.c (fc_charset_table): The registry to use to lookup windows-1251 charset is microsoft-cp1251, not windows-1251. (Bug#40097) --- src/ftfont.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ftfont.c b/src/ftfont.c index 2b442ead4b..6b549c3ddf 100644 --- a/src/ftfont.c +++ b/src/ftfont.c @@ -119,7 +119,7 @@ #define SYMBOL_FcChar8(SYM) (FcChar8 *) SDATA (SYMBOL_NAME (SYM)) { "jisx0213.2004-1", { 0x20B9F }}, { "viscii1.1-1", { 0x1EA0, 0x1EAE, 0x1ED2 }, "vi"}, { "tis620.2529-1", { 0x0E01 }, "th"}, - { "windows-1251", { 0x0401, 0x0490 }, "ru"}, + { "microsoft-cp1251", { 0x0401, 0x0490 }, "ru"}, { "koi8-r", { 0x0401, 0x2219 }, "ru"}, { "mulelao-1", { 0x0E81 }, "lo"}, { "unicode-sip", { 0x20000 }}, -- 2.19.1.816.gcd69ec8cde --=-=-=--