From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: assq_no_quit... huh? Date: Fri, 20 Dec 2024 06:00:35 +0100 Message-ID: References: <87zfkrp0da.fsf.ref@yahoo.com> <87zfkrp0da.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22426"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 20 06:01:49 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOV93-0005lF-Rd for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Dec 2024 06:01:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOV8C-0001m3-Up; Fri, 20 Dec 2024 00:00:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOV84-0001lh-W5 for emacs-devel@gnu.org; Fri, 20 Dec 2024 00:00:49 -0500 Original-Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOV81-0004cA-8p for emacs-devel@gnu.org; Fri, 20 Dec 2024 00:00:47 -0500 Original-Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-aa67f31a858so264162966b.2 for ; Thu, 19 Dec 2024 21:00:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734670839; x=1735275639; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=NUzaFA/9zbQvgWs3ThDEQuuEr25GiKda5bEGEP/a+g8=; b=mSq9PEtqJ0WcflU70xohwMjV22L9VJ2ZPfQd1X1QHRlmyrlWa8jYJGs1avi5aNTtgg R784Y0sNt2uA4Kc073QQseGef0Cqq8wwiWQVkGh4QiPSAqDq8pWht42bVajPcfDI8ZVx JGFCqIMODnfojHIYgyw/OpGJOmoAxpNbTt/dButfeSdLIengZlsPtUq3dIKnnyzy/76d bT3YGXrFvbiKSWdKvW1r26FZ2P7G4QvDjwxFSM4t0diMkEwemyhAqstTLQqrazP4oJ1h Wxksh/DWsStkDiTq+6Fw3l5BQ64JDViSBFdxS5Lzty4G0sNu1LLZ2UN5bcBHX1WJXPw5 v8QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734670839; x=1735275639; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NUzaFA/9zbQvgWs3ThDEQuuEr25GiKda5bEGEP/a+g8=; b=WTPQGvMxUCZ54BP9c/DGsRSePjCBpN9SVhz8BHxmvgW5gciR1qsbDaxR69LihJ5hr1 p0zSb9Lfj5wxO/Q1K7A5dHbKns4wb5M/FRgAddLpj0F+ezTvxBTDpjtUlY2bQCdQDigk OoIyLp2y8GRPv9dIn65R1fC0QQ8y9XufdIW2gO6Rgm9f2J3nduqKe3gbhaplWlRnsmw/ 5sqFTQOgZ1rDG4PuEkKJC44fjgaay0Ao6Kmb5OniUW/GdZ3PmvJoBJ0m1gMNcyhOBxar 3gIqO2wIFxOLNNaFKwOR+zFqZITp6dh1iT8qAo790uDzPzrH541M7HVXdByDlBAJvNtc 1uXw== X-Gm-Message-State: AOJu0YwbM5aPAw1Qo00qa9hnhDulyOfnm0UvxeOqKY0kYvJspRfDyd56 OLbRQhxwIl1mJV8CZL0xoh5CMF1AI5qU6UGodyhT5enMXXWhA5546XNUpA== X-Gm-Gg: ASbGncuhxuSwvmQTEl0U4zMwO3Zyf/fpXjRiKJe6IrFMS19g2MnkyaAxUOvdkobzd4H dsPzajagx7z5AYYQox6kDTDHSCWaUvGijUH47I/twZ2yvYB9d0LqADwmQWBFuKhN/gUsANFQshW wnAJ5aTGhDi6nybn/g8HVg1K4YDXwcb0CAoeFHnpsFm9Gp0MWkTYahsRmoWbZZPKtH/4g98hz8j GC0uOqUy9fJdHitYhE2uWGWs6gJv2/rU+N8G+401+3P1u1+QpcDofpCRk1y+dGNyyJp9YWtjRnW Bl3xGBX6etA4m1wa+zA3SWz4Y7neOUYu2/lx+6isvaSidg6ohxeLttv0gxVU X-Google-Smtp-Source: AGHT+IEk3tWL3w8JjdzizdktifegEMQlaclsYBvFot7ZCVVK7xaaPW1lgXxiEu4CSyxGW8Wq0VWzAg== X-Received: by 2002:a17:907:9728:b0:aa6:82e8:e896 with SMTP id a640c23a62f3a-aac26958bc8mr88268466b.0.1734670838447; Thu, 19 Dec 2024 21:00:38 -0800 (PST) Original-Received: from pro2 (p200300e0b70a560050feb175441df3ce.dip0.t-ipconnect.de. [2003:e0:b70a:5600:50fe:b175:441d:f3ce]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e8961cbsm136418666b.62.2024.12.19.21.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2024 21:00:37 -0800 (PST) In-Reply-To: <87zfkrp0da.fsf@yahoo.com> (Po Lu's message of "Fri, 20 Dec 2024 10:13:53 +0800") Received-SPF: pass client-ip=2a00:1450:4864:20::629; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326771 Archived-At: Po Lu writes: > What's the meaning of this code? > > if (is_tty_frame (f)) > { > /* Ignore all invisble tty frames, children or root. */ > if (!FRAME_VISIBLE_P (root_frame (f))) > continue; > > /* Remember tty root frames which we've seen. */ > if (!FRAME_PARENT_FRAME (f) > && NILP (assq_no_quit (frame, tty_root_frames))) <=== > tty_root_frames = Fcons (frame, tty_root_frames); > } > > No alist is being constructed and consequently assq_no_quit always > returns nil. Thanks, that's a bug. It would have better been memq_no_quit but that doesn't seem to exist anymore. Will be fixed soon.