From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: CHENG Gao Newsgroups: gmane.emacs.devel Subject: emacs-unicode-2 branch - src/macterm.c function mac_set_unicode_keystroke_event - should it be reverted in cvs? Date: Thu, 22 Nov 2007 00:43:15 +0800 Organization: cyberhut.org Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1195664892 27308 80.91.229.12 (21 Nov 2007 17:08:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Nov 2007 17:08:12 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 21 18:08:18 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Iut3C-0008EF-0v for ged-emacs-devel@m.gmane.org; Wed, 21 Nov 2007 18:07:46 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iut2y-0007za-7s for ged-emacs-devel@m.gmane.org; Wed, 21 Nov 2007 12:07:32 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IuszD-0005iv-1k for emacs-devel@gnu.org; Wed, 21 Nov 2007 12:03:39 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IuszA-0005hM-B0 for emacs-devel@gnu.org; Wed, 21 Nov 2007 12:03:38 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IuszA-0005hG-26 for emacs-devel@gnu.org; Wed, 21 Nov 2007 12:03:36 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Iusz9-0004kr-9t for emacs-devel@gnu.org; Wed, 21 Nov 2007 12:03:35 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IusrE-0007ub-68 for emacs-devel@gnu.org; Wed, 21 Nov 2007 16:55:24 +0000 Original-Received: from 222.94.199.202 ([222.94.199.202]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 21 Nov 2007 16:55:24 +0000 Original-Received: from chenggao by 222.94.199.202 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 21 Nov 2007 16:55:24 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 75 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 222.94.199.202 User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.0 (darwin) Cancel-Lock: sha1:eiSf/Xog+kDJISnaA72hZI/79xE= X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83790 Archived-At: In src/macterm.c (emacs-unicode-2 branch), function mac_set_unicode_keystroke_event is as below: ,---- | static void | mac_set_unicode_keystroke_event (code, buf) | UniChar code; | struct input_event *buf; | { | int charset_id, c1, c2; | | if (code < 0x80) | { | buf->kind = ASCII_KEYSTROKE_EVENT; | buf->code = code; | } | else if (code < 0x100) | { | if (code < 0xA0) | charset_id = CHARSET_8_BIT_CONTROL; | else | charset_id = charset_latin_iso8859_1; | buf->kind = MULTIBYTE_CHAR_KEYSTROKE_EVENT; | buf->code = MAKE_CHAR (charset_id, code, 0); | } | else | { | if (code < 0x2500) | charset_id = charset_mule_unicode_0100_24ff, | code -= 0x100; | else if (code < 0x33FF) | charset_id = charset_mule_unicode_2500_33ff, | code -= 0x2500; | else if (code >= 0xE000) | charset_id = charset_mule_unicode_e000_ffff, | code -= 0xE000; | c1 = (code / 96) + 32, c2 = (code % 96) + 32; | buf->kind = MULTIBYTE_CHAR_KEYSTROKE_EVENT; | buf->code = MAKE_CHAR (charset_id, c1, c2); | } | } `---- >From reading this group (gmane.emacs.devel) I got impression that this function is mis-re-introduced and should be reverted to OLD version as below: ,---- | static void | mac_set_unicode_keystroke_event (code, buf) | UniChar code; | struct input_event *buf; | { | int charset_id, c1, c2; | | if (code < 0x80) | buf->kind = ASCII_KEYSTROKE_EVENT; | else | buf->kind = MULTIBYTE_CHAR_KEYSTROKE_EVENT; | buf->code = code; | } `---- Is this correct? If so, could you please revert it in cvs. Considering the situation that TRUNK is buildable and usable in MacOSX, and emacs-unicode-2 is buildable (with this revert), it may be meaningful even though Carbon port is *to some extent* deprecated and declared unsupported. After all, Cocoa port (http://emacs-app.sf.net) is not officially planned to merge, and Mac port is only one step away from working. -- Numquam minus solus quam cum solus