From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build Date: Fri, 14 Dec 2018 17:16:46 +0100 Message-ID: References: <20181214085417.15440.18845@vcs0.savannah.gnu.org> <20181214085418.6616820538@vcs0.savannah.gnu.org> <831s6kgrtj.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1544804102 15788 195.159.176.226 (14 Dec 2018 16:15:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 14 Dec 2018 16:15:02 +0000 (UTC) Cc: ari.roponen@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 14 17:14:58 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXq77-0003uy-BR for ged-emacs-devel@m.gmane.org; Fri, 14 Dec 2018 17:14:57 +0100 Original-Received: from localhost ([::1]:34343 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXq98-0001Uj-Sr for ged-emacs-devel@m.gmane.org; Fri, 14 Dec 2018 11:17:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXq91-0001Ud-7M for emacs-devel@gnu.org; Fri, 14 Dec 2018 11:16:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXq8v-00030s-QB for emacs-devel@gnu.org; Fri, 14 Dec 2018 11:16:55 -0500 Original-Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:54264) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXq8v-00030C-Ja; Fri, 14 Dec 2018 11:16:49 -0500 Original-Received: by mail-wm1-x332.google.com with SMTP id y1so6184438wmi.3; Fri, 14 Dec 2018 08:16:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=wNV+mWWnvRG6hwxghVUWMw44w210euD6lI+6DsiiSEc=; b=Ai/kt8r8jtWGmO6s8j5JSVgXbMfZyC2GV3wCFfC43P9pSYDlHxsK58SaYzwy06GUSS tlybupf2FsBMiEIEZFJ0Rhb3ZMhHRYJwO4ksCL2+gTYQ0eYHGkVhyLCSF3KpdOMCJ2OY ADQwmHhI9vlsjcHZm1P/5OLqoGJ/c3GInAB+T6fYqTpELpbaIipKlR+cjMhSjiC7XsYR EJ36UIWV4CHogbdy37hVXI0u7ozQ+Ll5ElTsJoIjpxaJ6FKaIPBXvmoLR3jOTEMEIViG m2qT5byaONBeAuU5XJU1ge4KFMoNJgYp4gGmN6X1LyW7ct9zUhffZWePLEQonaYOJGM5 ArDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=wNV+mWWnvRG6hwxghVUWMw44w210euD6lI+6DsiiSEc=; b=kVtRwFLpJUZfaRtzFUk9btsZdMjW7k0aBJlq5TK2i9T5r60ysCC2fMpfzOkPEFRb1H ptCkNpOqFfHuhkrotg+DRBVl4aja2NPYyoZjmdKCjzp3brD8lydzoAS6blomkE3QaLrE 6VGQHAvnipImpnsNSTDZ6+n/9IvJyvp9H85F5SR5DwdVcLqpf4Jptemb+qGnQ6knr06a Kup/p2BdLkNwlRd6kFp+2Y7tNCPhTJ4KeJR1Dg5HC7Mikj5+ZTGvlUCIZ4uxEzrjwdXH Q/y2tXpqEzXxeKqv1gdeYOHKpn5f2QYYf5T229P8vyC/bbDg2BLq45cCu+ogB9Vz6qmw i3Mg== X-Gm-Message-State: AA+aEWZwMUSvS8EAGjJXk8s+011g06LgPEg39gQwumIDS6EvDzLS+gfi VBgLFFIp79WhHYGCZmN5Pk4= X-Google-Smtp-Source: AFSGD/UaLVuS79S19IT/+sWXd8D7KkyS6rHWbb9Z6NZRjkaZklXS7u23y3+9HxO5xNZSD5wdZkUh1w== X-Received: by 2002:a7b:c5cc:: with SMTP id n12mr1138832wmk.149.1544804208279; Fri, 14 Dec 2018 08:16:48 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id e16sm6324816wrn.72.2018.12.14.08.16.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 Dec 2018 08:16:47 -0800 (PST) In-Reply-To: <831s6kgrtj.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 14 Dec 2018 15:29:12 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::332 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231841 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Date: Fri, 14 Dec 2018 13:18:41 +0100 >> Cc: Ari Roponen >>=20 >> Eli, what would be your preferred type of solution to avoid this in >> future? > > If at all possible, I prefer a single definition of each struct, with > as few #ifdef's as possible. If some member is not used in some > configuration, I prefer to have it anyway, unless it cannot be > compiled in the configuration(s) that don't use it (e.g., because it > uses a data type that is only visible in some configurations). > Aligning ftfont.c and ftcrfont.c is pretty easy. Did you want me to try to unify xftfont.c in there as well? I=CA=BCm tempted to get rid of ftxfont.c as well, unless someone is actually still using that. [1] Robert Footnotes: [1] How many different font backends can we come up with using only 3 letters?