From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build Date: Tue, 18 Dec 2018 14:01:35 +0100 Message-ID: References: <20181214085417.15440.18845@vcs0.savannah.gnu.org> <20181214085418.6616820538@vcs0.savannah.gnu.org> <831s6kgrtj.fsf@gnu.org> <83pnu4f45d.fsf@gnu.org> <837eg8dpd6.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1545142159 2573 195.159.176.226 (18 Dec 2018 14:09:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Dec 2018 14:09:19 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 18 15:09:15 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZG3a-0000UH-RA for ged-emacs-devel@m.gmane.org; Tue, 18 Dec 2018 15:09:10 +0100 Original-Received: from localhost ([::1]:53808 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZG5h-0002cw-6I for ged-emacs-devel@m.gmane.org; Tue, 18 Dec 2018 09:11:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZG17-0007OL-2n for emacs-devel@gnu.org; Tue, 18 Dec 2018 09:06:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZG12-0001ns-Qi for emacs-devel@gnu.org; Tue, 18 Dec 2018 09:06:37 -0500 Original-Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:45696) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZG12-0001li-El for emacs-devel@gnu.org; Tue, 18 Dec 2018 09:06:32 -0500 Original-Received: by mail-wr1-x435.google.com with SMTP id t6so15854450wrr.12 for ; Tue, 18 Dec 2018 06:06:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=yjmbaEBngisSC600j7sJ1mfAoErPyo6XRMR32F5ZMYw=; b=px1UT1jGC8mEcST1jIXbVoBQPZER1VC36TrpCPu8XwolvzMbXavsT+vbCExbyjPFsR e2/BoRLXz9s6jDc5xPVwb0xfMeJ2AeJPMKxuir8fDJs0EldYWiGn7N4Ejx+O+Kpg2td9 LoW/QTtelb92pByJfWB2qAYWVWhgRktq9sd9M5+VDcENX8Q9WIONc0zzMxYTJIvSr1EW 0ssMmm7R459LzS0XoQf/8qjoaM27+Bw5eQmbyxOwJJPEV1AYvdO/vMjjnhZl7MAqLwIk jrIoYSgQd1zVrevQRiw6ATSgBmnEupKjVNpnzqGvANSed8RztxuCQXEriTQAHG3WHJC4 GRTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=yjmbaEBngisSC600j7sJ1mfAoErPyo6XRMR32F5ZMYw=; b=nkEfeHYWuiu7+oe/jiCkoODFt580ajuWeQtOaaibd8fBEsQJvOJDQMUU24jisr1JvN s0DJCHzTGx+WlA+rDIvP/fdqNS5HbUJvRXmGi4NxzlDTCcvfh4ZtMhPT50O+vFB/pwvd 6V6sB6BxV2XbMGz8j/3UFqn/HP6B2hhaN3vqUK5qNs01JtsQFVKzJbKaJ9y82w+sP45n 0SehsA6XTboJquzJXpPGJKrMbzeRjATD9KlDpFHowXBV0y9ZjP3ZMDPSVoRPSJsRkcw0 H7KNkJxDZVd5i7j9vgotPceB68Dt+PI2SIwzCG8mD0aoEXNMAyGO/1z7WwFT+QIAjwoM /I1Q== X-Gm-Message-State: AA+aEWadUt8v1gmYpcNuvZr7X+Vt3Yc6T5qIT/Vp0+sU9Av5Tlin2eo+ r1oVgrvnzXAdLeXujSwVIL3v9IuS X-Google-Smtp-Source: AFSGD/Wzo1lFwTX9eUUqy2K6RO4oy5u7ye0Fpkd3LVQA/aYBNI65WxKCfgMJKVG0eM9pT/5VDNCDyA== X-Received: by 2002:adf:ef50:: with SMTP id c16mr14606177wrp.198.1545138097826; Tue, 18 Dec 2018 05:01:37 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id k19sm4391689wre.5.2018.12.18.05.01.36 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Dec 2018 05:01:36 -0800 (PST) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: (Robert Pluim's message of "Tue, 18 Dec 2018 09:49:55 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::435 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231903 Archived-At: Robert Pluim writes: > Eli Zaretskii writes: >>> I had a quick go at this. I=CA=BCve not measured the memory difference,= but >>> I can do if people thinks this refactor is worth it. Apart from the >>> unification of the three struct definitions, most of the patch is >>> mechanical changes. >> Given that my cairo build of emacs opens only 4 fonts on startup, and the freetype one only 2, I think the memory issue is nonexistent. >> Thanks, this LGTM, and is a significant improvement, IMO. If no one >> objects in a few days, please push. >> >> P.S. Will this have any problems with the harfbuzz branch? > > Apart from having to adjust the addition to the struct in question > done on the harfbuzz branch, I don=CA=BCt think so. Probably there will be > a merge conflict, I can help out with that if needed. Having looked closer, there might be a few more conflicts, but nothing too complicated to handle. Mainly a few instances of struct ftfont_info -> struct font_info Robert