From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 8542f66 2/3: Automatically rotate images in image-mode based on Exif data Date: Wed, 30 Oct 2019 17:15:01 +0100 Message-ID: References: <20190922122352.13822.75583@vcs0.savannah.gnu.org> <20190922122354.5232A207FC@vcs0.savannah.gnu.org> <87tv7qthqi.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="48499"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 30 17:15:25 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPqd2-000CV2-20 for ged-emacs-devel@m.gmane.org; Wed, 30 Oct 2019 17:15:24 +0100 Original-Received: from localhost ([::1]:42382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPqd0-000835-UF for ged-emacs-devel@m.gmane.org; Wed, 30 Oct 2019 12:15:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53783) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPqcl-00082v-F1 for emacs-devel@gnu.org; Wed, 30 Oct 2019 12:15:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPqcj-0002nv-EF for emacs-devel@gnu.org; Wed, 30 Oct 2019 12:15:07 -0400 Original-Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:54933) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iPqcj-0002mx-7t for emacs-devel@gnu.org; Wed, 30 Oct 2019 12:15:05 -0400 Original-Received: by mail-wm1-x336.google.com with SMTP id g7so2727183wmk.4 for ; Wed, 30 Oct 2019 09:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=dN7i1Y0t6DVkJ47JfJjfj1j14zv16hwSW8sEY2k+0Ok=; b=XAWDhTeL6AGkAsvp92wzzwZ5vmegibcNjYcSNwZ40F79uF5wsyUmUjOPzDgnioPOBW 4snQOFpNMnQmsI76FNMH1I6TB2be4mCuD9aC5bXRn38VbcEbbdsGLPAd6CoQJGuJ7Nij L1cfZACCHB/RSXcqq2fyqoP0ZQoUGs4qpgxEUGbeo42rPJFbveQddeCuFuGRi35ZorH0 +5innrVxWeI4x7cy2nOOMD3RzIx4x5pEPFOxaTmW+pPTTY0j2uYSiSZgE/zMsEfCFay1 1l+jDpZdP6hHd9LudwjysJRbNQt7cV+Vw5CQELB/crd7o9Ot/EIqKuPVlP+wVx3ygdvc QaBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=dN7i1Y0t6DVkJ47JfJjfj1j14zv16hwSW8sEY2k+0Ok=; b=BePp/Lum8R3NQBLnW7UzXzsGzA5zVZA6dH49nxgrE6PCWkNMbEiOiFyUKGkTFG9LBG HstCCJp6ykoq3KH6GIgyfc7FJ7CuQqYghvohl22ohfDzcaqKbDMpjQByJiOvrzAtoKmj fDp7v3LqEfo8txRfny7yz2DHDBGvgNbNfX04tf94Z1BkY8moCiaIVSdxZJshFLpwSI/I jFaopfAUT5n8hVYj9hqQNYTb/a/fYgBMCLEyUbMWE2CfsGU8DOBJrhP+kAuPgBSO9eZx NyaN9fGPIPAY/GI6+41k5GWH4tUwEXErGoK0mufh61zNz3MG3PG/Y0KDRZycCs3porL/ SPrA== X-Gm-Message-State: APjAAAV1MSQkmKbqIHGk8cwWg+zQiA0B3LMQqd3DPWrVCzgt3SByxurR JlvWgVdhGy4bQzpOxY8LBkVa2wWU X-Google-Smtp-Source: APXvYqySUGaFozbQ0y7TTa2fwRLzLLnnltf8p+xIgnF1lJxz2pQU3QadOcJzEQOFG+/7YzcqSlpBMQ== X-Received: by 2002:a1c:9d07:: with SMTP id g7mr245065wme.53.1572452103493; Wed, 30 Oct 2019 09:15:03 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:10a:f31e:f8db:2aab]) by smtp.gmail.com with ESMTPSA id t134sm503121wmt.24.2019.10.30.09.15.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2019 09:15:02 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <87tv7qthqi.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 30 Oct 2019 15:45:09 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::336 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241633 Archived-At: >>>>> On Wed, 30 Oct 2019 15:45:09 +0100, Lars Ingebrigtsen said: Lars> Robert Pluim writes: >> So I attempted to visit a PNG file from emacs, and got a buffer >> containing the image data, and the following in *Messages* >>=20 >> Cannot display image: ((app1 (cdr (assq 65505 (exif--parse-jpeg))))) >>=20 >> It=CA=BCs unclear to me whether emacs should be able to display PNG >> natively here. (featurep 'png) is nil, but this is on macOS, which >> allegedly has builtin support for PNG. In any case I=CA=BCm not expe= cting >> an error message about exif data. Lars> I'm unable to reproduce this error -- viewing png images works fi= ne for Lars> me. Lars> Could you post a backtrace? The easiest is probably to say Lars> M-: (image-toggle-display-image) Debugger entered--Lisp error: (error "The buffer is not in Image mode") signal(error ("The buffer is not in Image mode")) error("The buffer is not in Image mode") image-toggle-display-image() eval((image-toggle-display-image) t) eval-expression((image-toggle-display-image) nil nil 127) funcall-interactively(eval-expression (image-toggle-display-image) nil ni= l 127) call-interactively(eval-expression nil nil) command-execute(eval-expression) which is a whole different error (although the modeline says "(Fundamental Image)" Robert