From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] remove save and undo text on tool-bar for gtk version Date: Wed, 30 Sep 2020 18:58:40 +0200 Message-ID: References: <87blhntdl6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28806"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Caio Henrique Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 30 19:02:09 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNfUW-0007Lu-5U for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Sep 2020 19:02:08 +0200 Original-Received: from localhost ([::1]:37084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNfUU-0002xn-RK for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Sep 2020 13:02:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNfRG-0000Ph-Tn for emacs-devel@gnu.org; Wed, 30 Sep 2020 12:58:47 -0400 Original-Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:35064) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNfRF-0007nS-Cg for emacs-devel@gnu.org; Wed, 30 Sep 2020 12:58:46 -0400 Original-Received: by mail-wr1-x444.google.com with SMTP id e16so2621947wrm.2 for ; Wed, 30 Sep 2020 09:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=1rpwVnc1M0U1sB4yw8HNeKAM4zEUct2DSoju99yB3t4=; b=nRFfpwqSkhq8MD9NTg294ZkvM05uc4sn09FdoiT/SaKbbi2xWOArupJ+pncQf3MzhH STbyOYgVgusXC2f3KK2HaZgsXiWyicqYaAzw/Qqsggq+M2JEXQeGDH9yQAae7LjRDN7q pWLeRvDW2gvGUm/VvzUNiUlqDDfJxBVg2hhILIFRQjLOKqbMx3KApVzN9BMDnDlqoL7s nSZMSwO1d4MQ/ugJCkHLzuGc7Dxe35STXWSiSXhn/jFCjmj1W07JRKZNkLyxmDDXTGKZ cV1ffVMZxkQygYfrjv/hEKF1As4sbge1k2SUCo3PJxV027nt0Lrp4wWwDtfOO4VsoFvk f7nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=1rpwVnc1M0U1sB4yw8HNeKAM4zEUct2DSoju99yB3t4=; b=CElY+aHaY2CF9dlT4rLjL45qc25PeRXMYP60AfVCkyw3bhOfG70qo9MdvuP/tnCfYD VSlEu/ycK3BDGEC4usCG8+crapK9RgkDaxEoNogw0TsHiV5p8c0Tn35Wv055dRbigpU8 UglZmZ+VRPer+aPr3u2uajv4rXJd4yBjhHwjcR+9kUZJUFEbud3IPLDd7QssZa5k5kJN 9LbN+Su1AaqTkbS/ImDlJ3CjNnt873T+AG3A866hx2a9AH2VSqLhKaO8BmJa9ProuItw v5NQplksQozaXdoO8Ki/h7R8nKI6tji/xYM+WYtyFTEZmI1QP2aZpCIKMVRyg8Q2XeJe 0E8A== X-Gm-Message-State: AOAM533yj4udgRSksrSMMkLajuLGJd5UyQ4D0atbDx+oAjz1tewMwh7E zwCmiN/PkHiDrct1KngYxp63/+CzCxo= X-Google-Smtp-Source: ABdhPJzBKbjAfd2gbv/ZQ219yjfw1txQ0UnsQyZbARmeUceJSfktWXrGQvGwP1D9bXu/Nz6AfcSnDQ== X-Received: by 2002:adf:f70d:: with SMTP id r13mr4265974wrp.317.1601485121850; Wed, 30 Sep 2020 09:58:41 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:215c:b811:c438:6af7]) by smtp.gmail.com with ESMTPSA id d9sm3669631wmb.30.2020.09.30.09.58.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 09:58:41 -0700 (PDT) Gmane-Reply-To-List: yes In-Reply-To: <87blhntdl6.fsf@gmail.com> (Caio Henrique's message of "Wed, 30 Sep 2020 13:48:53 -0300") Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=rpluim@gmail.com; helo=mail-wr1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256770 Archived-At: >>>>> On Wed, 30 Sep 2020 13:48:53 -0300, Caio Henrique said: Caio> Hi, these suggestions to improve the tool-bar consistency and als= o save Caio> horizontal space got lost in the "Changes for emacs 28" discussio= n, so Caio> I'm changing the subject. This only affects the gtk version, AFAI= K windows Caio> only shows the icons. Caio> There were two proposals: Caio> 1 - remove :vertonly from all tool-bar items and change the defau= lt Caio> value of tool-bar-style to image Caio> 2 - simply add :vertonly to save and undo Caio> IMO option 1 is better, since option 2 makes the value text-image= -horiz Caio> useless. =20 Caio> This variable only affects the GTK+ toolkit version of Emacs. *= /); Caio> - Vtool_bar_style =3D Qnil; Caio> + Vtool_bar_style =3D Qimage; =20 Caio> DEFVAR_INT ("tool-bar-max-label-size", tool_bar_max_label_size, Caio> doc: /* Maximum number of characters a label can have to be = shown. Caio> ____________ If you do this you'll need to update the version tag for tool-bar-style in lisp/cus-start.el to "28.1" as well. FWIW option 1 sounds good to me (although I don=CA=BCt use the toolbar at all). Robert --=20