From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: dangling markers Date: Sun, 30 Jun 2024 14:48:25 +0200 Message-ID: References: <87v81u85hv.fsf@localhost> <87frsx81m2.fsf@localhost> <87cyo180y2.fsf@localhost> <874j9d7zqe.fsf@localhost> <87sewvg6lw.fsf@localhost> <87sewuk4l6.fsf@localhost> <87r0celi67.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24952"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier , emacs-devel@gnu.org, Eli Zaretskii , eller.helmut@gmail.com To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 30 14:49:00 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNtzI-0006Io-Af for ged-emacs-devel@m.gmane-mx.org; Sun, 30 Jun 2024 14:49:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNtyt-0006Ff-07; Sun, 30 Jun 2024 08:48:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNtyp-0006F2-Qv for emacs-devel@gnu.org; Sun, 30 Jun 2024 08:48:32 -0400 Original-Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNtyn-0000AI-Kn; Sun, 30 Jun 2024 08:48:30 -0400 Original-Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a72b3e1c14cso231917166b.1; Sun, 30 Jun 2024 05:48:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719751707; x=1720356507; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DuJxl3k4MfseldnkyZ9qJl2vPyw6YPPzBx1t3DFrssg=; b=Q/rBD2vFQsc5na9yi5DIOr8qfUE3SIKzmRng5ZEJELDHG/wYBD/CuBLt/Gf91aP4Th GeMx4vi+efgjz7VpRMtwbn5wEhrIMDdZSf6Zxcdp2/YXQlQr9gHUn9xVz5QKgwrYOgho 7NQMibgHKl4LBFzP2Mz2mf2dgig8vxMAwAaG82rh8g4ZaMvwZYVRjnmaBFUJW3AOnEnI TNjconXWsuyIm5kYzfRkHX0MOwROpK6w/GNoOX8BBlZY8eJdseZUU6NO8pYeneEBo/Bi lHaSYQmDeyE1MuMgWuWUZdiu5SiffiRYsiVnBUgQvm2XG35HLPFmyV0vAXIg+x57qwq0 +FEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719751707; x=1720356507; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DuJxl3k4MfseldnkyZ9qJl2vPyw6YPPzBx1t3DFrssg=; b=D2Tp8IeJ1o1gn+WA3CCm0VSUyqChU1KFMXXCV2AEoE031OnpYrsS8V08AlSs66+JA0 6SFyKPwG1vA+ji+vCE0ODTUDMkVJhttP0JnpI55pOw00P0AJcxmg/mwaCfMq+lSsjbXf AsUIY4tfCnE0Jn+fWO/gled+0KwwUiqZjNlyeCviZaVGEQWdm9UpP4DE+OyHozd71mxO wK+eulNoZyXdYao8HLD+Rd/cZgFSutcOPYaTmSHI9vKCKsledxbuJaU5HvWOHipMP6RI SBdefLHlPBTF1cTGhDvN6TAOaHV/lF7F+A2Pt7OvLhz/RmW3JW8n0EJhY/kXKepuqVZn yCsw== X-Forwarded-Encrypted: i=1; AJvYcCX52X1MaYGWcHhBAF11aJ0AdZnkBTNU1kVxW+pWINaRqKTTa/gQWqGqPS+uiI5IoI7eqGstv9B1R9tOJwUVtfgHrDEdBqF8NGB01RAI8BB1DUc= X-Gm-Message-State: AOJu0YytooltVA0AdD7kKtK5h+91r+ddUgLomk07smpOQc4Dy0Wpz82B OYXZMv/02vuW8VKWUAADo/dIZQMbk1JuLn2ALu3Hy0AFhQTx70dnqBhurQ== X-Google-Smtp-Source: AGHT+IGSHLHa5iD9dhRPWzcR3jVhtyv0zvySiE+s5jy39giho24vIH5jesjNWi1JPtLAWJ8/Ea13wQ== X-Received: by 2002:a17:907:7211:b0:a6f:e456:4207 with SMTP id a640c23a62f3a-a75144a2799mr265235866b.61.1719751707001; Sun, 30 Jun 2024 05:48:27 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36a45.dip0.t-ipconnect.de. [217.227.106.69]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72aaf18c67sm239821266b.42.2024.06.30.05.48.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jun 2024 05:48:26 -0700 (PDT) In-Reply-To: <87r0celi67.fsf@localhost> (Ihor Radchenko's message of "Sun, 30 Jun 2024 12:38:24 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320962 Archived-At: Ihor Radchenko writes: > Gerd M=C3=B6llmann writes: > >> Thanks, Ihor, that looks promising. I've now also pushed a quick and >> dirty add_marker in O(1), that's why I reverted. to get that on top. >> Works for me... >> >> A comparison of how it feels compared to master would also be interestin= g. > > igc.c: In function =E2=80=98fix_marker_vector=E2=80=99: > igc.c:1701:34: error: passing argument 1 of =E2=80=98NILP=E2=80=99 makes = pointer from integer without a cast [-Wint-conversion] > 1701 | if (NILP (v->contents[i] && !NILP (old))) > | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~ > | | > | int > In file included from igc.c:31: > lisp.h:1499:21: note: expected =E2=80=98Lisp_Object=E2=80=99 {aka =E2=80= =98struct Lisp_X *=E2=80=99} but argument is of type =E2=80=98int=E2=80=99 > 1499 | (NILP) (Lisp_Object x) > | ~~~~~~~~~~~~^ Soory, either I've fat-fingered something, or clang 15 is a bit too permissive :-( Psuhed a fix.