Re: Question about dubious code for terminal frames

["Gerd Möllmann" <gerd.moellmann@gmail.com>]

martin rudalics <rudalics@gmx.at> writes:

>> Get the physical dimensions and then what?  We must record the
>> dimensions in the frames and windows that share that terminal.  Which
>> is what change_frame_size does.
>>
>>> Outside of get_tty_size I'd make FrameCols/Rows const. I guess that
>>> frame size changes could remain as is. Only that setting FrameCols/Rows
>>> is none of their business. It's an input for them, not an output.
>>
>> Martin will correct me if I'm wrong, but I think the current code
>> already does what you want: it only changes FrameCols/Rows when the
>> terminal was really resized.
>
> I started reading this thread just now and I have to go through the
> preceding posts to even understand the problem.  The only thing I can
> say at the moment is that I locally made a change to adjust_frame_size
> where I moved the assignment of the new frame values headed by
>
>   /* Assign new sizes.  */
>
> up in the code.  The context is now as:

I think I have the above here. It reads

  /* Assign new sizes.  */
  FRAME_COLS (f) = new_text_cols;
  FRAME_LINES (f) = new_text_lines;

Anyway. My problem is setting FrameCols/Rows in adjust_frame_size. It's
not guaranteed that the terminal's size has indeed changed when that is
done.