From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Andrew Choi Newsgroups: gmane.emacs.devel Subject: Re: Status of MAC/W32/X consolidation and some questions. Date: Tue, 11 Mar 2003 08:31:04 -0700 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <5xadg38lnj.fsf@kfs2.cua.dk> <5x7kb6empm.fsf@kfs2.cua.dk> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7BIT X-Trace: main.gmane.org 1047397015 25938 80.91.224.249 (11 Mar 2003 15:36:55 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 11 Mar 2003 15:36:55 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Mar 11 16:36:54 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18sloE-0006kD-00 for ; Tue, 11 Mar 2003 16:36:54 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18smB1-0000sX-00 for ; Tue, 11 Mar 2003 17:00:27 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18slnG-0004KG-01 for emacs-devel@quimby.gnus.org; Tue, 11 Mar 2003 10:35:54 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18slkc-0003LX-00 for emacs-devel@gnu.org; Tue, 11 Mar 2003 10:33:10 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18slkM-0002vV-00 for emacs-devel@gnu.org; Tue, 11 Mar 2003 10:32:56 -0500 Original-Received: from shawidc-mo1.cg.shawcable.net ([24.71.223.10] helo=pd2mo3so.prod.shaw.ca) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18slic-0001fF-00 for emacs-devel@gnu.org; Tue, 11 Mar 2003 10:31:06 -0500 Original-Received: from pd3mr2so.prod.shaw.ca (pd3mr2so-ser.prod.shaw.ca [10.0.141.178])2002)) with ESMTP id <0HBL00AOKCFULD@l-daemon> for emacs-devel@gnu.org; Tue, 11 Mar 2003 08:31:06 -0700 (MST) Original-Received: from pn2ml7so.prod.shaw.ca (pn2ml7so-qfe0.prod.shaw.ca [10.0.121.151]) by l-daemon (iPlanet Messaging Server 5.1 HotFix 0.8 (built May 12 2002)) with ESMTP id <0HBL00M15CFU3R@l-daemon> for emacs-devel@gnu.org; Tue, 11 Mar 2003 08:31:06 -0700 (MST) Original-Received: from owlbear.local.shawmail (h68-144-207-94.cg.shawcable.net [68.144.207.94]) by l-daemon (iPlanet Messaging Server 5.1 HotFix 0.8 (built May 12 2002)) with ESMTP id <0HBL00MMRCFTRA@l-daemon> for emacs-devel@gnu.org; Tue, 11 Mar 2003 08:31:06 -0700 (MST) In-reply-to: <5x7kb6empm.fsf@kfs2.cua.dk> Original-To: storm@cua.dk (Kim F. Storm) User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Original-Lines: 29 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12274 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12274 storm@cua.dk (Kim F. Storm) writes: > Andrew Choi writes: > > > storm@cua.dk (Kim F. Storm) writes: > > > > > [...] > > > > > > On MAC, I noticed two places in macterm.c where FRAME_X_P is tested > > > rather than FRAME_MAC_P, which basically means that the corresponding > > > code _IS_NOT_ executed: > > > > > > * In x_flush, the call to XFlush is conditioned by FRAME_X_P > > > > > > * In XTframe_up_to_date, the entire code is conditioned by FRAME_X_P. > > > > > > Could a MAC expect please check these two strange-looking cases for > > > me, thanks! > > > > These are probably just cases I copied code from w32term.c or xterm.c > > and then forgot to change them. They will work fine if changed to > > FRAME_MAC_P. > > Ok. I'll fix those. > > I just wonder: Does it also run fine without changing them > (i.e. without executing the conditioned code?) Yes, it does.