all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chris Moore <dooglus@gmail.com>
Cc: emacs-pretest-bug@gnu.org, ihs_4664@yahoo.com, emacs-devel@gnu.org
Subject: Re: Directory name completion blocks when it shouldn't
Date: Tue, 19 Dec 2006 21:16:39 +0100	[thread overview]
Message-ID: <m2odpzy72w.fsf@chrislap.local> (raw)
In-Reply-To: <E1Gw73J-00053Y-In@fencepost.gnu.org> (Richard Stallman's message of "Sun\, 17 Dec 2006 20\:12\:25 -0500")

Richard Stallman <rms@gnu.org> writes:

>     Is it feasible to fix read-file-name to obey the predicate
>     in the completion case?  It could be that the reason it doesn't
>     do so was the difficulty of implementing that case efficiently.
>
> Since no one else seemed interested in this, I did it.

I think you've introduced a new bug - 

  lisp/net/ange-ftp.el.gz line 3980:
    (defun ange-ftp-file-name-completion (file dir)
  is being called like:
    (ange-ftp-file-name-completion "" "/a:/" 'file-exists-p)

and

  lisp/net/tramp.el.gz line 2859:
    (defun tramp-handle-file-name-completion (filename directory)
  is being called like:
    (tramp-handle-file-name-completion "" "/a:/" 'file-exists-p)

in both cases the functions expect 2 arguments, and they're being
passed 3.

I reported this earlier today:

  Message-Id: <m2zm9km3rc.fsf@chrislap.local>
  To: emacs-pretest-bug@gnu.org
  Subject: TRAMP: error when completing filename

without realising that this was related to the recent "Directory name
completion blocks when it shouldn't" fix.

  reply	other threads:[~2006-12-19 20:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <871wng3yyw.fsf@leeloo.anubex.internal>
     [not found] ` <m3wt57vkvv.fsf@kfs-l.imdomain.dk>
     [not found]   ` <el1l03$j4p$1@sea.gmane.org>
     [not found]     ` <E1GrSYo-0004AE-I3@fencepost.gnu.org>
     [not found]       ` <m2vekme8vg.fsf@chrislap.local>
2006-12-17  5:37         ` Directory name completion blocks when it shouldn't Richard Stallman
2006-12-18  1:12           ` Richard Stallman
2006-12-19 20:16             ` Chris Moore [this message]
2006-12-20  6:14               ` Michael Albinus
2006-12-20 10:28                 ` Sascha Wilde
2006-12-20 13:24                   ` Michael Albinus
2006-12-20 14:08                     ` Sascha Wilde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2odpzy72w.fsf@chrislap.local \
    --to=dooglus@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=emacs-pretest-bug@gnu.org \
    --cc=ihs_4664@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.