From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sascha Wilde Newsgroups: gmane.emacs.devel Subject: Re: Pathnames with two (or more) slashes in Makefile.c Date: Mon, 29 Jan 2007 21:21:12 +0100 Message-ID: References: <45BC7182.7010704@swipnet.se> <45BDAAFD.6050402@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1170102073 19017 80.91.229.12 (29 Jan 2007 20:21:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 29 Jan 2007 20:21:13 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jan =?iso-8859-1?Q?Dj=E4rv?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 29 21:21:08 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HBczx-0005DQ-L7 for ged-emacs-devel@m.gmane.org; Mon, 29 Jan 2007 21:21:05 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HBczw-000314-T9 for ged-emacs-devel@m.gmane.org; Mon, 29 Jan 2007 15:21:04 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HBczl-000305-KB for emacs-devel@gnu.org; Mon, 29 Jan 2007 15:20:53 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HBczk-0002y5-Aw for emacs-devel@gnu.org; Mon, 29 Jan 2007 15:20:53 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HBczk-0002xl-5k for emacs-devel@gnu.org; Mon, 29 Jan 2007 15:20:52 -0500 Original-Received: from ns.km1136.keymachine.de ([62.141.58.119] helo=km1136.keymachine.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1HBczj-0005qo-Mt for emacs-devel@gnu.org; Mon, 29 Jan 2007 15:20:52 -0500 Original-Received: from kenny.sha-bang.de (xdslcd060.osnanet.de [89.166.131.60]) (authenticated bits=0) by km1136.keymachine.de (8.12.11.20060308/8.12.10) with ESMTP id l0TKKf0f026209; Mon, 29 Jan 2007 21:20:42 +0100 Original-Received: from wilde by kenny.sha-bang.de with local (Kenny MUA v.0409034.42) ID 1HBd04-0005K1-LK; Mon, 29 Jan 2007 21:21:12 +0100 In-Reply-To: <45BDAAFD.6050402@swipnet.se> (Jan =?iso-8859-1?Q?Dj=E4rv's?= message of "Mon\, 29 Jan 2007 09\:06\:21 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.93 (gnu/linux) X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:65600 Archived-At: --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Jan Dj=E4rv wrote: > Sascha Wilde skrev: >> Jan Dj=E4rv wrote: [...] >> So the problem is, that the double slash is written unquoted to >> Makefile.c where it gets interpreted as a comment. >> >> This is IMO a bug. >> >> When generating Makefile.c consecutive slashes hould either be reduced >> to one or appropriately quoted. > > Actually it was a bug in my patch, I should not use #define if a > double slash may be present. I briefly checked the other #define:s in > Makefile.in and mostly the valuse comes from s/*.h or m/*.h, so we > have control over these. > > I've checked in a fix, please try it. Sorry, maybe I'm seriously missing something here, but I can't see such a change by you, neither in CVS nor in the ChangeLog. And, build still fails... :-( FWIW: my workaround for now looks like this: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=emacs-configure-hotfix.patch --- a/configure.in +++ b/configure.in @@ -3256,6 +3256,7 @@ < Makefile.c > junk1.c sed -e '1,/start of cpp stuff/d'\ -e 's,/\*\*/#\(.*\)$,/* \1 */,' \ + -e 's,\(#.*\)//\+,\1/,g' \ < Makefile.c > junk.c $CPP $undefs -I. -I$srcdir/src $CPPFLAGS junk.c | \ sed -e 's/^ / /' -e '/^#/d' -e '/^[ ]*$/d' > junk2.c @@ -3272,6 +3273,7 @@ < Makefile.c > junk1.c sed -e '1,/start of cpp stuff/d'\ -e 's,/\*\*/#\(.*\)$,/* \1 */,' \ + -e 's,\(#.*\)//\+,\1/,g' \ < Makefile.c > junk.c $CPP $undefs -I. -I$srcdir/src $CPPFLAGS junk.c | \ sed -e 's/^ / /' -e '/^#/d' -e '/^[ ]*$/d' > junk2.c --=-=-= cheers sascha -- Sascha Wilde -.-. ..- .-. .. --- ... .. - -.-- -.- .. .-.. .-.. . -.. - .... . -.-. .- - --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --=-=-=--