From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Markus Triska Newsgroups: gmane.emacs.bugs Subject: bug#2982: 23.0.92; `vc-diff' behaves inconsistently with git Date: Sat, 18 Apr 2009 21:51:55 +0200 Message-ID: References: Reply-To: Markus Triska , 2982@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1240085083 25815 80.91.229.12 (18 Apr 2009 20:04:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 18 Apr 2009 20:04:43 +0000 (UTC) Cc: gnu-emacs-bug@moderators.isc.org, 2982@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 18 22:05:59 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LvGnT-0008Ot-5H for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Apr 2009 22:05:56 +0200 Original-Received: from localhost ([127.0.0.1]:38496 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LvGm4-00016K-6B for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Apr 2009 16:04:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LvGld-0000t3-4u for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 16:04:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LvGlX-0000qL-S6 for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 16:04:00 -0400 Original-Received: from [199.232.76.173] (port=56328 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LvGlX-0000q1-8z for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 16:03:55 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:60499) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LvGlW-00024U-HQ for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 16:03:54 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3IK3pSF014273; Sat, 18 Apr 2009 13:03:52 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n3IK03KI013012; Sat, 18 Apr 2009 13:00:03 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Markus Triska Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 18 Apr 2009 20:00:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2982 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.124008432911571 (code B ref -1); Sat, 18 Apr 2009 20:00:03 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 18 Apr 2009 19:52:09 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3IJq6Kf011559 for ; Sat, 18 Apr 2009 12:52:07 -0700 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LvGa6-000820-EO for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 15:52:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LvGa1-00081b-FL for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 15:52:06 -0400 Original-Received: from [199.232.76.173] (port=42795 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LvGa1-00081Y-9K for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 15:52:01 -0400 Original-Received: from pinatubo-2.switch.ch ([130.59.1.10]:40786 helo=pinatubo.switch.ch) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LvGa0-0000JM-Jj for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 15:52:01 -0400 Original-Received: from [213.165.64.20] (helo=mail.gmx.net) by pinatubo.switch.ch with smtp (Exim 4.63) (envelope-from ) id 1LvGZy-0007Ji-DD for gnu-emacs-bug@moderators.isc.org; Sat, 18 Apr 2009 21:51:58 +0200 Original-Received: (qmail invoked by alias); 18 Apr 2009 19:51:57 -0000 Original-Received: from chello062178240212.3.14.tuwien.teleweb.at (EHLO mt-imac.local) [62.178.240.212] by mail.gmx.net (mp003) with SMTP; 18 Apr 2009 21:51:57 +0200 X-Authenticated: #4064391 X-Provags-ID: V01U2FsdGVkX1/IBCEhoPDIhH8efyH5f1z4oM21JZXhf4dCIg17pW F9cu6WvQU2a/sX Original-Received: by mt-imac.local (Postfix, from userid 501) id 974C52BC0CB; Sat, 18 Apr 2009 21:51:55 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Sat, 18 Apr 2009 15:38:25 -0400") X-Y-GMX-Trusted: 0 X-FuHaFi: 0.74 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-CrossAssassin-Score: 2 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sat, 18 Apr 2009 16:03:59 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27334 Archived-At: Stefan Monnier writes: > In the case of git, it would be easier to ask git the status Exactly, after what you explained before, it seems to me that Emacs should ask git for the status of the file right after saving as well, and store the new modification time (you explained that it already does it after opening). Of course, this does not solve the problem of external modtime changes, but it seems that this is solvable as well: Before running diff, Emacs could ask git whether the status has changed. It seems that this would yield consistent behaviour of vc-diff regardless of whether the file was just opened or saved in between.