From: David Engster <deng@randomsample.de>
To: Eric Schulte <schulte.eric@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: How to fix Emacs24 compiler warning w/o breaking code for previous versions
Date: Fri, 17 Jun 2011 09:19:07 +0200 [thread overview]
Message-ID: <m2oc1x2adw.fsf@ibookg4-c2.pc.gwdg.de> (raw)
In-Reply-To: <87oc1xd62s.fsf@gmail.com> (Eric Schulte's message of "Thu, 16 Jun 2011 10:44:27 -0700")
Eric Schulte writes:
> I've been working to address the elisp byte-compiler warnings thrown
> while compiling the current Org-mode head, and I do not know how to
> address cases where the byte-compiler insists on usage of a new feature
> not present in older Emacsen without breaking Org-mode support of those
> Emacsen. I'm writing to ask for the "best practices" approach?
Not that I think that it is a particularly good example (it's pretty
messy, actually), but you might want to look at the Gnus-git repo for
ideas. The problem with the "ignore warnings on older Emacsen" approach
is that pretty soon you will have difficulties spotting those warnings
which signal a real problem. This is especially true if you're using a
continuous build system like Gnus does.
At least for this automatic build, it currently restricts warnings to
the classes '(free-vars unresolved callargs redefine suspicious). If a
spurious warning from one of that classes pops up, we make the
byte-compiler be quite about it (see lisp/lpath.el in the Gnus repo).
-David
prev parent reply other threads:[~2011-06-17 7:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 17:44 How to fix Emacs24 compiler warning w/o breaking code for previous versions Eric Schulte
2011-06-17 3:10 ` Stefan Monnier
2011-06-17 3:42 ` Jambunathan K
2011-06-17 6:34 ` Stephen J. Turnbull
2011-06-17 7:17 ` Eli Zaretskii
2011-06-19 21:14 ` Daniel Colascione
2011-06-20 7:53 ` David Kastrup
2011-06-17 4:45 ` Eric Schulte
2011-06-17 7:19 ` David Engster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2oc1x2adw.fsf@ibookg4-c2.pc.gwdg.de \
--to=deng@randomsample.de \
--cc=emacs-devel@gnu.org \
--cc=schulte.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.