From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: fix latent bug in process.c Date: Wed, 15 Aug 2012 17:01:51 +0200 Message-ID: References: <87txw661c8.fsf@fleche.redhat.com> <87ipcm4i79.fsf@fleche.redhat.com> <87393p4jne.fsf@fleche.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1345042925 3823 80.91.229.3 (15 Aug 2012 15:02:05 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 15 Aug 2012 15:02:05 +0000 (UTC) Cc: Emacs discussions To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 15 17:02:05 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T1f6i-0007Xr-AK for ged-emacs-devel@m.gmane.org; Wed, 15 Aug 2012 17:02:04 +0200 Original-Received: from localhost ([::1]:50298 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1f6h-000868-7s for ged-emacs-devel@m.gmane.org; Wed, 15 Aug 2012 11:02:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1f6f-00085z-52 for emacs-devel@gnu.org; Wed, 15 Aug 2012 11:02:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1f6a-0007l7-EM for emacs-devel@gnu.org; Wed, 15 Aug 2012 11:02:01 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.10]:42443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1f6a-0007l0-86 for emacs-devel@gnu.org; Wed, 15 Aug 2012 11:01:56 -0400 Original-Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3Wxv5s74D9z3hhjk; Wed, 15 Aug 2012 17:01:53 +0200 (CEST) X-Auth-Info: fy6/D5+Fgd247vVw7tsLB5s2EM6cB02+kIZ5fXp4k5w= Original-Received: from igel.home (ppp-93-104-154-237.dynamic.mnet-online.de [93.104.154.237]) by mail.mnet-online.de (Postfix) with ESMTPA id 3Wxv5s0ThFzbbh1; Wed, 15 Aug 2012 17:01:53 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 501) id 9A531CA2A2; Wed, 15 Aug 2012 17:01:52 +0200 (CEST) X-Yow: .. I think I'll KILL myself by leaping out of this 14th STORY WINDOW while reading ERICA JONG'S poetry!! In-Reply-To: <87393p4jne.fsf@fleche.redhat.com> (Tom Tromey's message of "Tue, 14 Aug 2012 08:45:25 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 212.18.0.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152558 Archived-At: Tom Tromey writes: > * process.c (wait_reading_process_output): Check Writeok bits, > not write_mask. > > diff --git a/src/process.c b/src/process.c > index 0be624a..18775c5 100644 > --- a/src/process.c > +++ b/src/process.c > @@ -4792,7 +4792,7 @@ wait_reading_process_output (intmax_t time_limit, int nsecs, int read_kbd, > && d->func != 0 > && (d->condition & FOR_READ) != 0) > d->func (channel, d->data, 1); > - if (FD_ISSET (channel, &write_mask) > + if (FD_ISSET (channel, &Writeok) Yes, that looks like a real bug. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."