From: Leo <sdl.web@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 12796@debbugs.gnu.org, Kim Storm <storm@cua.dk>
Subject: bug#12796: Optimize `ido-completing-read' for larger lists with flex matching enabled
Date: Wed, 07 Nov 2012 18:38:31 +0800 [thread overview]
Message-ID: <m2obj9pujc.fsf@gmail.com> (raw)
In-Reply-To: <5099DE35.2060402@yandex.ru> (Dmitry Gutov's message of "Wed, 07 Nov 2012 08:06:13 +0400")
On 2012-11-07 12:06 +0800, Dmitry Gutov wrote:
> That was actually a good advice. As far as I can tell, most of the
> speed improvement comes from the following change
I seem to have some speedup on the flex matching part with the following
patch.
(tested on a ~9000 list with each item containing ~35 chars)
diff --git a/ido.el b/ido.el
index 31d5279d..dc623110 100644
--- a/ido.el
+++ b/ido.el
@@ -3710,6 +3710,25 @@ (defun ido-get-bufname (win)
(cons buf ido-bufs-in-frame)))))
;;; FIND MATCHING ITEMS
+(defun ido-chars-in-string (chars str &optional prefix)
+ (let ((p 0)
+ (len (length chars))
+ c)
+ (catch 'exit
+ (when (zerop len)
+ (throw 'exit t))
+ (when (zerop (length str))
+ (throw 'exit nil))
+ (setq c (aref chars 0))
+ (when (and prefix (/= c (aref str 0)))
+ (throw 'exit nil))
+ (dotimes (i (length str))
+ (when (eq (aref str i) c)
+ (setq p (1+ p))
+ (when (>= p len)
+ (throw 'exit t))
+ (setq c (aref chars p))))
+ (>= p len))))
(defun ido-set-matches-1 (items &optional do-full)
;; Return list of matches in items
@@ -3783,13 +3802,10 @@ (defun ido-set-matches-1 (items &optional do-full)
ido-enable-flex-matching
(> (length ido-text) 1)
(not ido-enable-regexp))
- (setq re (mapconcat #'regexp-quote (split-string ido-text "") ".*"))
- (if ido-enable-prefix
- (setq re (concat "\\`" re)))
(mapc
(lambda (item)
(let ((name (ido-name item)))
- (if (string-match re name)
+ (if (ido-chars-in-string ido-text name ido-enable-prefix)
(setq matches (cons item matches)))))
items))
matches))
next prev parent reply other threads:[~2012-11-07 10:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-04 5:58 bug#12796: Optimize `ido-completing-read' for larger lists with flex matching enabled Dmitry Gutov
2012-11-04 8:32 ` Leo
2012-11-04 13:53 ` Stefan Monnier
2012-11-04 17:05 ` Dmitry Gutov
2012-11-05 5:37 ` Dmitry Gutov
2012-11-06 1:45 ` Stefan Monnier
2012-11-06 11:03 ` Kim Storm
2012-11-06 15:38 ` Dmitry Gutov
2012-11-06 16:45 ` Kim Storm
2012-11-07 5:41 ` Dmitry Gutov
2012-11-05 20:57 ` Dmitry Gutov
2012-11-07 2:27 ` Leo
2012-11-07 4:06 ` Dmitry Gutov
2012-11-07 10:38 ` Leo [this message]
2012-11-07 21:54 ` Dmitry Gutov
2012-11-08 2:00 ` Leo
2012-11-08 4:14 ` Stefan Monnier
2012-11-08 7:36 ` Leo
2012-11-08 14:05 ` Stefan Monnier
2012-11-10 17:52 ` Dmitry Gutov
2012-11-10 22:51 ` Stefan Monnier
2012-11-10 23:01 ` Dmitry Gutov
2012-11-10 23:31 ` Stefan Monnier
2020-09-13 16:14 ` Lars Ingebrigtsen
2012-11-08 2:05 ` Stefan Monnier
2012-11-08 4:29 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2obj9pujc.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=12796@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.