From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Wiegley Newsgroups: gmane.emacs.devel Subject: Re: emacs-25 2460cfa: * doc/lispref/lists.texi (Association Lists): Document 'alist-get'. Date: Fri, 22 Jan 2016 09:50:28 -0800 Message-ID: References: <20160116143238.27391.97533@vcs.savannah.gnu.org> <8737ttx5dm.fsf@web.de> <83oachbgz0.fsf@gnu.org> <87vb6pih39.fsf@web.de> <83h9i9besq.fsf@gnu.org> <87mvs1ieql.fsf@web.de> <83bn8hbcpp.fsf@gnu.org> <87a8o1ics6.fsf@web.de> <838u3lbbe8.fsf@gnu.org> <87vb6osb0o.fsf@web.de> <87h9i86tke.fsf@web.de> <878u3in7ye.fsf@web.de> <83fuxq95jt.fsf@gnu.org> <83d1su94bn.fsf@gnu.org> <83twm66qjp.fsf@gnu.org> <87zivxesbp.fsf@web.de> Reply-To: John Wiegley NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1453485215 22865 80.91.229.3 (22 Jan 2016 17:53:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Jan 2016 17:53:35 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 22 18:53:28 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aMftm-0003cz-Sa for ged-emacs-devel@m.gmane.org; Fri, 22 Jan 2016 18:53:27 +0100 Original-Received: from localhost ([::1]:54971 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMftm-00060Z-5G for ged-emacs-devel@m.gmane.org; Fri, 22 Jan 2016 12:53:26 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMft9-0005rj-NU for emacs-devel@gnu.org; Fri, 22 Jan 2016 12:52:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMft8-0002f7-R7 for emacs-devel@gnu.org; Fri, 22 Jan 2016 12:52:47 -0500 Original-Received: from mail-pa0-x233.google.com ([2607:f8b0:400e:c03::233]:36320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMft6-0002cs-Dy; Fri, 22 Jan 2016 12:52:44 -0500 Original-Received: by mail-pa0-x233.google.com with SMTP id yy13so44899641pab.3; Fri, 22 Jan 2016 09:52:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:reply-to:mail-followup-to:mime-version:content-type; bh=6kE0fwEk2BQKbNRT1KdK6jDOsW1N2vwFus9aHVCAJCk=; b=q/kHdC4+MpCEU9/6bRYWRa8CU/lMATzP3hQOxQLCY/nFtxurZEiYVyr0HP2Zby64h6 uPJYCcMSfxvVNLeD0eB9an0BXuIxMjjBhOLzkO89zoTBeVSVcS2ZM7rBnwNXKRIx9jbI Umgna3c6LA55JQqNDzV88U5mQk4BFs+pAa3DnshYvdLesNX6ST0QuhmQMwxz+ran5wDy k5ljprgQIa0bbB+8Lu3bMzQoICluxjbt7G0tiXu2SX95NdoShb1q0r3u0NQkbFRHWLwn nq8vQbqagLQK16Zl5Ms33sd8E1TkycoBHHUb9/Hzob2O7UtiJ7Z9fGMk1RwOaz4zEk7q y8qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :references:user-agent:reply-to:mail-followup-to:mime-version :content-type; bh=6kE0fwEk2BQKbNRT1KdK6jDOsW1N2vwFus9aHVCAJCk=; b=Ax3xxiEuRtOhyplJCX+8fOUummC79QlvwbL6sSZIYbvMxPHNQkh54lQqziWJCntZCE g3lt98UIzs7s3gyQ3na+dRtQ1McHOYI8Fb9TbVrq6RhPGU+UdhLLt3Lv7PI+nrtH3IBU IurfPuv0/uorwUuIWbXmFs6REi3Pg5FvJFUnjY0rCqAcqlRq2qxm2fyrq4vjyeArtTmP z3xGLx03EvygUvfMgiOX//3rPd58FajQN+kmvs7i55lH7TokRrW9K1zwYYSmGm/yZBy2 pXHGdP1Fg4DdwLGgzyD9fH5t/fA8WhZmM835Xr05q6lCnOKQkuhLTDrsR9I1pkkxdNnP xMaA== X-Gm-Message-State: AG10YOSuea1yXBGK5wcrJLpA3GuFKHJzD4VQlLGyErrWLo9T9aO0ZgLvW0yjae7sdD5/Gw== X-Received: by 10.66.252.136 with SMTP id zs8mr6257041pac.110.1453485163522; Fri, 22 Jan 2016 09:52:43 -0800 (PST) Original-Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id i76sm11113840pfj.68.2016.01.22.09.52.41 (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 22 Jan 2016 09:52:41 -0800 (PST) X-Google-Original-From: "John Wiegley" Original-Received: by Vulcan.local (Postfix, from userid 501) id D3E01125A779B; Fri, 22 Jan 2016 09:52:40 -0800 (PST) In-Reply-To: <87zivxesbp.fsf@web.de> (Michael Heerdegen's message of "Fri, 22 Jan 2016 13:01:30 +0100") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (darwin) Mail-Followup-To: Michael Heerdegen , Eli Zaretskii , emacs-devel@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c03::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198587 Archived-At: >>>>> Michael Heerdegen writes: > Do you really think we should add a comment like that to the code? To > understand the definition, it's better to have a look at gv.el. After having > had a look, such a comment is not necessary anymore, since we have a more or > less trivial usage of `gv-letplace'. Well, some comment would have been nice; compare Eli's reaction, knowing he's a well seasoned Elisp developer. At the very least, a docstring that makes it obvious what the code is intending to accomplish. And `gv-letplace' is still a name that should be changed. Maybe `let-getf-setf'? -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2