From: Helmut Eller <eller.helmut@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 25071@debbugs.gnu.org
Subject: bug#25071: 26.0.50; Various Forth related improvements for etags
Date: Wed, 30 Nov 2016 17:55:02 +0100 [thread overview]
Message-ID: <m2oa0wdi1l.fsf@gmail.com> (raw)
In-Reply-To: <83inr5q9i4.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 30 Nov 2016 17:21:07 +0200")
On Wed, Nov 30 2016, Eli Zaretskii wrote:
>> With the patch, etags creates explicit tag names. That works better in
>> combination with tag-exact-match-p.
>
> Can you explain more about this? Explicit tag names bloat the TAGS
> files, so other languages don't use that by default, except where
> really needed.
Yes, the TAGS file becomes at most twice as big. That's a minor
disadvantage that I'm happy to trade for even tiny improvements in
precision.
I also note that, Gforth (the GNU Forth implementation) ships a TAGS
file for the built-in definitions with explicit tag names (usually
installed in /usr/share/gforth/<version>/TAGS). They use the Gforth
compiler, not etags, to create this TAGS file. Obviously they aren't
bothered by the bloat either.
> Could it be that only some tags need to be written as
> explicit, e.g. because they contain some special characters?
Yes, that's the main reason. E.g. with the old version a source file
test.fth with this content:
: (foo) 123 ;
produced this TAGS file:
\f
test.fth,17
: (foo)\x7f(foo.1,0
Hmm, it already created explicit tag names before. But with "(foo" as
name, which is wrong. The name should be "(foo)".
In case your are not familiar with Forth syntax: names in Forth are
separated by whitespace and can contain "(", ")", "," or other
non-whitespace characters. A word in parentheses like "(foo)" is a
widely used naming convention for internal/auxiliary definitions.
The old version of etags.c used get_tag which uses notinname to find the
end of the name, but that excludes ")", which is wrong for Forth.
> Also, it sounds like you send a patch wrt emacs-25 branch; if so,
> please rebase on master, since that is where the patch will be pushed
> eventually. The test files are in a different place on master.
The patch is against master, but I wrote the wrong filenames in the
changelog, because I copied part of it from an old commit message.
Helmut
next prev parent reply other threads:[~2016-11-30 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 11:29 bug#25071: 26.0.50; Various Forth related improvements for etags Helmut Eller
2016-11-30 15:21 ` Eli Zaretskii
2016-11-30 16:55 ` Helmut Eller [this message]
2016-11-30 17:47 ` Eli Zaretskii
2016-11-30 19:32 ` Helmut Eller
2016-12-01 16:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2oa0wdi1l.fsf@gmail.com \
--to=eller.helmut@gmail.com \
--cc=25071@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.